Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added new flag for serial process #166

Merged
merged 3 commits into from
Jul 26, 2021
Merged

Conversation

vamsimundra
Copy link
Contributor

@vamsimundra vamsimundra commented Jul 20, 2021

What does this PR do?

Added a new boolean flag --serial for the "force:data:bulk:upsert" command, which will allow the job to run serially.
Github Issue Link : forcedotcom/cli#882

What issues does this PR fix or reference?

@W-8934566@

Copy link
Contributor

@WillieRuemmele WillieRuemmele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice Job!

Copy link
Contributor

@mshanemc mshanemc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice tests.

in the PR description, can you put a link to the github WI? That makes this PR show up on the WI as a "mention" so anyone who's following that sees that it's being done.

serial: flags.boolean({
char: 'r',
description: messages.getMessage('flags.serial'),
default: false,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can leave off default:false since that's the automatic value for booleans when they aren't there.

@cristiand391 cristiand391 merged commit 9c70cbd into main Jul 26, 2021
@cristiand391 cristiand391 deleted the upsert_serial_mode branch July 26, 2021 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants