Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: export Spinner and remove console.error #223

Merged
merged 9 commits into from
Feb 20, 2023
Merged

feat: export Spinner and remove console.error #223

merged 9 commits into from
Feb 20, 2023

Conversation

mdonnalley
Copy link
Contributor

@mdonnalley mdonnalley commented Feb 16, 2023 •
edited
Loading

  • Exports Spinner so that it can more easily be stubbed
  • Replaces console.error with this.logToStderr so that it can be stubbed
  • Adds stubUx, stubSfCommandUx, stubSpinner, and stubPrompter functions

Depends on oclif/core#629

@W-12429800@

@mdonnalley mdonnalley merged commit 04475a0 into main Feb 20, 2023
@mdonnalley mdonnalley deleted the mdonnalley/make-tests-easier branch February 20, 2023 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@mdonnalley