fix: throw from catch #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillieRuemmele
approved these changes
Feb 21, 2023
| @@ -526,3 +536,8 @@ export namespace SfCommand { | |||
| context?: string; | |||
| } | |||
| } | |||
|
|
|||
| function removeEmpty(obj: Record<string, unknown>): Record<string, unknown> { | |||
There was a problem hiding this comment.
non-blocking: are we sure we want to remove empty key/values from the error? it might make it hard for consumers to depend on the type returned?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
catchso that unit tests can useshouldThrowSfErrorinstance checks incatchto prevent testing issues with multiple versions of sfdx-core being used across the dependency tree[skip-validate-pr]