Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: use current inquirer #479

Merged
merged 17 commits into from
Jan 5, 2024
Merged

feat!: use current inquirer #479

merged 17 commits into from
Jan 5, 2024

Conversation

mshanemc
Copy link
Contributor

@mshanemc mshanemc commented Jan 3, 2024

BREAKING CHANGE: ESM-only

BREAKING CHANGE: removes cross-cloud hooks (deployer, deauthorizer, etc)

BREAKING CHANGE: removes Prompter module

BREAKING CHANGE: remove option to barrel-import from Ux

@W-14674359@


The following PRs use the pre-release package as "proof of correctness" and should be updated once this merges. They can be checked out and built to do manual QA. They also explore what changes this PR will cause.

BREAKING CHANGE: ESM-only

BREAKING CHANGE: removes cross-cloud hooks (deployer, deauthorizer, etc)

BREAKING CHANGE: removes Prompter module

BREAKING CHANGE: remove option to barrel-import from Ux
Copy link
Contributor

@mdonnalley mdonnalley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me 👍

Looks like you have some merge conflicts though. Also, I'm assuming that the failing nuts are expected?

README.md Outdated Show resolved Hide resolved
@mdonnalley
Copy link
Contributor

QA

Generated new sf plugin using sf dev generate plugin, linked this branch of sf-plugins-core to it.

🟢 this.confirm prompts user for Y/n answer
🟢 this.confirm defaults to defaultAnswer after 10 second timeout
this.confirm hangs until timeout despite being answered

🟢 this.secretPrompt prompts user and input is hidden
this.secretPrompt hangs until timeout despite being answered

@mdonnalley
Copy link
Contributor

QA
Generated new sf plugin using sf dev generate plugin, linked this branch of sf-plugins-core to it.

🟢 this.confirm prompts user for Y/n answer
🟢 this.confirm defaults to defaultAnswer after 10 second timeout
🟢 this.confirm cancels timeout if answer is given

🟢 this.secretPrompt prompts user and input is hidden
🟢 this.secretPrompt cancels timeout if answer is given

@mshanemc
Copy link
Contributor Author

mshanemc commented Jan 4, 2024

Changes look good to me 👍

Looks like you have some merge conflicts though. Also, I'm assuming that the failing nuts are expected?

PDR needs salesforcecli/plugin-deploy-retrieve#866 to even compile without the Deployer hook stuff.

The other 2 (org and signups) are expected results of the breaking changes in here.

MIGRATING_V5-V6.md Outdated Show resolved Hide resolved
MIGRATING_V5-V6.md Outdated Show resolved Hide resolved
MIGRATING_V5-V6.md Outdated Show resolved Hide resolved
MIGRATING_V5-V6.md Outdated Show resolved Hide resolved
@mdonnalley mdonnalley marked this pull request as ready for review January 5, 2024 21:25
@mdonnalley mdonnalley requested a review from a team as a code owner January 5, 2024 21:25
@mdonnalley mdonnalley merged commit 77e33ab into main Jan 5, 2024
22 of 42 checks passed
@mdonnalley mdonnalley deleted the sm/esm branch January 5, 2024 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants