Peer review ("Vertaisarviointi")

[matiastamsi]

The project was cloned: 22.4.2021 18:48

Peer review I

First of all, I have to say that your project is unbeliveable! The documentation is so clear and wide that it feels so professional! The code is pure and I can't find anything really worth of telling. Well, something is required so here is some minor things that you perhaps see worth of thinking!

• Those 15,000 words are quite plenty but could it be more? I don't really know if this has any impact to your project but perhaps a larger collection could serve you more?

• I see that there are more comments and javadoc in the SpellChecker than in the TrainSpellChecker. If this is a part of the final project remember to add those as well! Just like in the SpellChecker (really nicely done!). Same thing about tests etc.

• Hmm, perhaps the lines in the code could be divided when those go over the prefered length? For example, Netbeans suggests that by white/grey line how long it should be.

• Is there going to be tests for dao and ui as well? There is now tests only for domain. Maybe those are quite useless but maybe worth of something!

I really can't wait to see your demo and the project functioning when fully ready!

[sallasal]

Thank you for the feedback. I also was starting to think that I could use bigger dictionary. It does not any difference in the program, but it would improve the results, so that is a good idea and easy to implement. Thanks for the idea!