Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FlagChatAdapter Updates. #1

Merged
merged 7 commits into from Feb 11, 2023
Merged

FlagChatAdapter Updates. #1

merged 7 commits into from Feb 11, 2023

Conversation

IODevBlue
Copy link
Contributor

Hello!

I am currently using this adapter in an application and I'd like to contribute minor changes I made to the FlagChatAdapter code.

Here's a summary:

  • Upgraded the project to Gradle 7.4.2
  • Changed compileSdkVersion from 27 to 32
  • Migrated project to use androidx
  • Replaced Kotlin synthetics with regular findViewById()
  • Improved KDoc comments.

salmaanahmed
salmaanahmed approved these changes Feb 11, 2023
View reviewed changes
Copy link
Owner

@salmaanahmed salmaanahmed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@salmaanahmed salmaanahmed merged commit b4df351 into salmaanahmed:master Feb 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@salmaanahmed salmaanahmed salmaanahmed approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@IODevBlue @salmaanahmed