[v2] Add QueryKeyAuthenticator

[Gummibeer]

Some APIs use a query param based Key authentication. For sure that's possible with a defaultQuery() method but somehow feels wrong. So how about a QUeryAuthenticator or similar named class with a signature like new QueryAuth(string $name, string $value). 🤔

[Sammyjo20]

Ooh yeah that could be good! So it just adds a query parameter with the key and value?

[Gummibeer]

Exactly. Wasn't sure about naming but yeah, like ?key=abc123

[Sammyjo20]

I can definitely add that in - but I do think defaultQuery on the connector is a good approach too, you would just need to accept the API key through the constructor of the connector.

[Gummibeer]

Yeah, doing it right now that way. But The authenticator feels better. And one question regarding priority.
If I use defaultQuery() to define key=1, the query authenticator with key=2 and in the request itself also defaultQuery() with key=3 - which one would be used? My hope would be that the authenticator has priority over both defaultQuery() methods - as it explicitly calls addQuery(). 🤔

[Sammyjo20]

I think that defaultQuery will take priority over the authenticator unfortunately. This is something that has been looked over a lot in v2 and the authenticator is basically the last thing in v2. Apologies

[Gummibeer]

Okay, so right now the change would be (some way) even worse. 😅
But good to know and I think that in V2 an authenticator like that would make sense.

[Sammyjo20]

This has now been added to the v2 branch!