Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor naming of Crawler class to Spider #73

Open
stooit opened this issue Aug 29, 2019 · 0 comments
Open

Refactor naming of Crawler class to Spider #73

stooit opened this issue Aug 29, 2019 · 0 comments
Assignees
@derklempner
Labels
enhancement New feature or request

Comments

@stooit
Copy link
Contributor

stooit commented Aug 29, 2019

Description
Currently the Crawler class refers to the crawler that generates URL list, but this is at odds with other named things (e.g DomCrawler) which causes slight confusion.

Proposed solution
Refactor \Migrate\Crawler to Spider which won't clash with the namespace

Additional context
None
@stooit stooit added the enhancement New feature or request label Aug 29, 2019
@derklempner derklempner changed the title Refactor naming of Crawler class Refactor naming of Crawler class to Spider Aug 30, 2019
@derklempner derklempner self-assigned this Aug 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@derklempner derklempner

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stooit @derklempner