Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Needs a top-level 'kafka' directory #1

Closed
whiteinge opened this issue Sep 27, 2016 · 4 comments
Closed

Needs a top-level 'kafka' directory #1

whiteinge opened this issue Sep 27, 2016 · 4 comments

Comments

@whiteinge
Copy link

Everything here looks great for a first-rev. The only needed change is to move all the files in the root dir under a top-level 'kafka' directory so that the repo can be included in Salt's GitFS or file_roots settings.

Docs describing that directory structure.

@blbradley
Copy link
Contributor

Eeeek! I noticed this while integrating the formula.

@blbradley
Copy link
Contributor

blbradley commented Sep 27, 2016

I had it fixed in my account's repo right after you pushed the commits. Mind doing a force push with my repo's commits to preserve history? I promise this will only happen once.

@whiteinge
Copy link
Author

GitHub disabled force-pushes for us at the Organization level as a special request so I'm afraid even admins can't do that. (I double-checked just now and I don't have access.)

This will need to be done as a commit against the existing history.

@blbradley
Copy link
Contributor

Ok! Thanks for checking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants