[BUG] some issues on CENT8/RHEL8

[noelmcloughlin]

Your setup

Formula commit hash / release tag

Versions reports (master & minion)

Salt 3000

Pillar / config used

---

Bug details

Describe the bug

The packages state throws errors on CentOS8:

[ERROR   ] Made the following changes:
'python3-dnf-plugin-versionlock' changed from 'absent' to '4.0.8-3.el8'

[ERROR   ] The following packages failed to install/update: yum-plugin-versionlock
The following packages were already installed: curl, bzip2, gzip
[ERROR   ] The following packages failed to install/update: yum-plugin-versionlock
The following packages were already installed: curl, bzip2, gzip
[ERROR   ] Command '['systemd-run', '--scope', 'yum', '-y', 'install', 'python-devel', 'python2-pip']' failed with return code: 1

[ERROR   ] stdout: Running scope as unit: run-r8905c4fd894b4d7993d8b3e9b79c8aa3.scope
SaltStack repo for RHEL/CentOS 8                510  B/s | 557  B     00:01
Failed to download metadata for repo 'saltstack'
Ignoring repositories: saltstack
Last metadata expiration check: 0:02:27 ago on Tue Apr 14 12:46:27 2020.
No match for argument: python-devel
Error: Unable to find a match: python-devel
[ERROR   ] retcode: 1
[ERROR   ] Error occurred installing package(s). Additional info follows:

errors:
    - Running scope as unit: run-r8905c4fd894b4d7993d8b3e9b79c8aa3.scope
      SaltStack repo for RHEL/CentOS 8                510  B/s | 557  B     00:01
      Failed to download metadata for repo 'saltstack'
      Ignoring repositories: saltstack
      Last metadata expiration check: 0:02:27 ago on Tue Apr 14 12:46:27 2020.
      No match for argument: python-devel
      Error: Unable to find a match: python-devel
[ERROR   ] Command '['systemd-run', '--scope', 'yum', '-y', 'install', 'policycoreutils-python']' failed with return code: 1

This is related saltstack/salt#54798

Steps to reproduce the bug

Expected behaviour

Attempts to fix the bug

I was thinking about introducing an osfingermap like this but not sure that is best way. Maybe osfamilymap should check major version. Not sure of ideal solution here.

CentOS-7:
  pkgs:
    required:
      pkgs:
        - yum-plugin-versionlock
  pips:
    required:
      pkgs:
        - python-devel
        - python2-pip

CentOS-8:
  pkgs:
    required:
      pkgs:
        - python3-dnf-plugin-versionlock
  pips:
    required:
      pkgs:
        - python3-devel
        - python3-pip

Red Hat Enterprise Linux Server-6: {}

Additional context

[noelmcloughlin]

State:

          ID: pkg_req_pkgs
    Function: pkg.installed
      Result: False
     Comment: Attempt 1: Returned a result of "False", with the following comment: "The following packages failed to install/update: yum-plugin-versionlock
              The following packages were already installed: curl, bzip2, gzip"
              Attempt 2: Returned a result of "False", with the following comment: "The following packages failed to install/update: yum-plugin-versionlock
              The following packages were already installed: curl, bzip2, gzip"
              The following packages failed to install/update: yum-plugin-versionlock
              The following packages were already installed: curl, bzip2, gzip
     Started: 10:45:54.194819
    Duration: 179760.26 ms
     Changes:
----------
          ID: wanted_pkgs
    Function: pkg.installed
      Result: False
     Comment: One or more requisite failed: packages.pkgs.pkg_req_pkgs
     Started: 10:48:54.143807
    Duration: 0.004 ms
     Changes:
----------
    ID: pip_req_pkgs
    Function: pkg.installed
      Result: False
     Comment: Error occurred installing package(s). Additional info follows:

              errors:
                  - Running scope as unit: run-r8905c4fd894b4d7993d8b3e9b79c8aa3.scope
                    SaltStack repo for RHEL/CentOS 8                510  B/s | 557  B     00:01
                    Failed to download metadata for repo 'saltstack'
                    Ignoring repositories: saltstack
                    Last metadata expiration check: 0:02:27 ago on Tue Apr 14 12:46:27 2020.
                    No match for argument: python-devel
                    Error: Unable to find a match: python-devel
     Started: 10:48:54.155019
    Duration: 3111.378 ms
     Changes: