Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Evaluate the semantic-pull-requests GitHub bot #54

Closed
myii opened this issue Feb 27, 2019 · 2 comments
Closed

Evaluate the semantic-pull-requests GitHub bot #54

myii opened this issue Feb 27, 2019 · 2 comments

Comments

@myii
Copy link
Member

myii commented Feb 27, 2019

Useful comment on a thread I was participating in: semantic-release/semantic-release#536 (comment). Leads to:

It can actually be configured for all repositories in one go. I'm trying it on all of my repos in the meantime to see how it fares.
@myii myii mentioned this issue Feb 27, 2019
Closed
@myii
Copy link
Member Author

myii commented Feb 27, 2019

I'm in two minds:

  • On the one hand, it is very useful to have such an immediate check, rather than waiting for commitlint to finish its run.
  • However, the bot has hardly any configuration options and it's ruleset seems very relaxed, so there are many commits that get through it that won't get through commitlint.

@myii
Copy link
Member Author

myii commented May 15, 2019

Our commitlint is pretty stringent so I don't think this bot is helpful really -- closing.

@myii myii closed this as completed May 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@myii