Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passing the coverage files explicitly. #136

Merged
merged 7 commits into from Aug 22, 2022

Conversation

s0undt3ch
Copy link
Member

Fixes #135

Signed-off-by: Pedro Algarvio palgarvio@vmware.com

Fixes saltstack#135

Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
@s0undt3ch s0undt3ch force-pushed the master branch 6 times, most recently from 475fde3 to 2c92406 Compare August 22, 2022 10:46
@codecov
Copy link

codecov bot commented Aug 22, 2022

Codecov Report

Merging #136 (ae4189a) into master (1ef05f9) will decrease coverage by 1.63%.
The diff coverage is 87.33%.

❗ Current head ae4189a differs from pull request most recent head f5e8b99. Consider uploading reports for the commit f5e8b99 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #136      +/-   ##
==========================================
- Coverage   86.07%   84.45%   -1.62%     
==========================================
  Files          96       96              
  Lines        5568     5296     -272     
  Branches      624      614      -10     
==========================================
- Hits         4792     4472     -320     
- Misses        597      628      +31     
- Partials      179      196      +17     
Flag Coverage Δ
Linux 84.35% <87.33%> (-1.05%) ⬇️
Py35 67.85% <62.68%> (+0.11%) ⬆️
Py36 84.31% <87.33%> (-0.37%) ⬇️
Py37 84.31% <87.33%> (-0.65%) ⬇️
Py38 ?
Py39 ?
PyTest61 67.87% <62.68%> (-1.28%) ⬇️
PyTest62 84.20% <87.33%> (-1.34%) ⬇️
PyTest70 84.28% <87.33%> (-1.30%) ⬇️
PyTest71 84.28% <87.33%> (-1.30%) ⬇️
Salt3005rc2 84.35% <87.33%> (?)
Windows ?
macOS ?
src 77.22% <83.88%> (-1.54%) ⬇️
tests 95.16% <93.88%> (-0.56%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/saltfactories/cli/cloud.py 89.37% <ø> (-0.43%) ⬇️
src/saltfactories/client.py 31.92% <0.00%> (-4.08%) ⬇️
src/saltfactories/daemons/master.py 83.69% <ø> (-0.44%) ⬇️
src/saltfactories/daemons/minion.py 79.35% <ø> (-1.90%) ⬇️
src/saltfactories/daemons/proxy.py 77.48% <ø> (-1.65%) ⬇️
src/saltfactories/plugins/factories.py 82.76% <ø> (-1.61%) ⬇️
...ltfactories/utils/saltext/engines/pytest_engine.py 29.73% <0.00%> (ø)
...gration/factories/daemons/container/test_minion.py 87.50% <ø> (-3.19%) ⬇️
src/saltfactories/plugins/__init__.py 80.65% <33.34%> (-19.35%) ⬇️
tests/conftest.py 91.38% <60.00%> (-0.42%) ⬇️
... and 86 more

Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
Signed-off-by: Pedro Algarvio <palgarvio@vmware.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

code_dir must always be passed for coverege support
1 participant