pprint is not consistent

[laroche]

On the first output "batch2" has curly braces {} around the output, but the other hosts do not. The second
output shows "None" as a failed connection. I think the zeromq connections should get better error
handling, ping checks together with connection closes.

best regards,

Florian La Roche

salt '*' cmd.run 'uname -a'
batch4.jur-linux.org: Linux batch4.jur-linux.org 2.6.32-220.13.1.el6.x86_64 #1 SMP Tue Apr 17 23:56:34 BST 2012 x86_64 x86_64 x86_64 GNU/Linux
batch1.jur-linux.org: Linux batch1.jur-linux.org 2.6.32-220.13.1.el6.x86_64 #1 SMP Tue Apr 17 15:16:22 CDT 2012 x86_64 x86_64 x86_64 GNU/Linux
batch3.jur-linux.org: Linux batch3.jur-linux.org 2.6.32-220.13.1.el6.x86_64 #1 SMP Tue Apr 17 23:56:34 BST 2012 x86_64 x86_64 x86_64 GNU/Linux
{'batch2.jur-linux.org': 'Linux batch2.jur-linux.org 2.6.32-220.13.1.el6.x86_64 #1 SMP Tue Apr 17 23:56:34 BST 2012 x86_64 x86_64 x86_64 GNU/Linux'}

salt '*' cmd.run 'uname -a'
{'batch2.jur-linux.org': None}
batch3.jur-linux.org: Linux batch3.jur-linux.org 2.6.32-220.13.1.el6.x86_64 #1 SMP Tue Apr 17 23:56:34 BST 2012 x86_64 x86_64 x86_64 GNU/Linux
batch1.jur-linux.org: Linux batch1.jur-linux.org 2.6.32-220.13.1.el6.x86_64 #1 SMP Tue Apr 17 15:16:22 CDT 2012 x86_64 x86_64 x86_64 GNU/Linux
batch4.jur-linux.org: Linux batch4.jur-linux.org 2.6.32-220.13.1.el6.x86_64 #1 SMP Tue Apr 17 23:56:34 BST 2012 x86_64 x86_64 x86_64 GNU/Linux

[thatch45]

What version is this? I fixed the None issue a few days ago. The braces issue is part of the outputter I need to track down

[thatch45]

These have been fixed in git head

[laroche]

The None issue seems to be gone, but I can still see the curly braces being added from time to time:

{'batch4.jur-linux.org': ' 09:34:18 up 18:50, 0 users, load average: 0.16, 0.20, 0.09'}
batch2.jur-linux.org: 09:34:18 up 20:50, 0 users, load average: 0.12, 0.15, 0.08
batch1.jur-linux.org: 09:34:18 up 21:23, 1 user, load average: 0.28, 0.22, 0.11
batch3.jur-linux.org: 09:34:18 up 18:50, 0 users, load average: 0.06, 0.15, 0.08

This is with current head...

best regards,

Florian La Roche

[thatch45]

heh, yes, sorry.

I am not sure what this is happening, something in pprint, I will look into it

[thatch45]

I am having trouble getting this to go away, pprint does not have any constructs that really help here, I might need to source dive.

I might also push this on off for a bit

[thatch45]

Moving to 0.10.5
We need to change the default outputter for test.ping to something else that will be consistent

[thatch45]

This was fixed a while back, the outputter used for test.ping is now txt which makes it consistent