Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Give clearer error message when top.sls is not found #1232

Closed
herlo opened this Issue May 9, 2012 · 5 comments

Comments

Projects
None yet
3 participants
Member

herlo commented May 9, 2012

When running state.highstate, I would get the following error message. I had my salt state in the incorrect place, but maybe it would be good to state where salt is looking for states as I couldn't tell I had it incorrect.

salt '*' state.highstate
roman.gooselinux.org:
----------
    State: - no
    Name:      states
    Function:  None
        Result:    False
        Comment:   No states found for this minion
        Changes:  
Owner

thatch45 commented May 9, 2012

Yes, this has come up a few times, I will look into it

Contributor

jhutchins commented May 11, 2012

59e0e85 should satisfy this request

Member

herlo commented May 11, 2012

I really don't think that commit solves the issue. I like the code you wrote there, but I think the comment should say something like 'top.sls not found'.

Contributor

jhutchins commented May 11, 2012

I reworked the wording at 078472e so it clearly says top.sls not found AND tells you where it thought it should be. Hopefully this gives people enough information to know what's wrong and how to fix it.

Owner

thatch45 commented May 11, 2012

I think this solves the issue, if you disagree @herlo please re-open

@thatch45 thatch45 closed this May 11, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment