Running salt as user fails. Naming conflict.

[victormuse]

It seems that ~/.salt is used both for local config file and local logging directory.

Running salt '*' test.ping exits with error code 1 and these messages:

[ERROR   ] An un-handled exception was caught by salt's global exception handler:
IOError: [Errno 21] Is a directory: '/var/data/services/jenkins/.salt'
Traceback (most recent call last):
  File "/usr/bin/salt", line 10, in <module>
    salt_main()
  File "/usr/lib/python2.6/site-packages/salt/scripts.py", line 135, in salt_main
    client.run()
  File "/usr/lib/python2.6/site-packages/salt/cli/__init__.py", line 56, in run
    local = salt.client.LocalClient(self.get_config_file_path())
  File "/usr/lib/python2.6/site-packages/salt/client/__init__.py", line 110, in __init__
    self.opts = salt.config.client_config(c_path)
  File "/usr/lib/python2.6/site-packages/salt/config.py", line 1994, in client_config
    os.path.expanduser('~/.salt')
  File "/usr/lib/python2.6/site-packages/salt/config.py", line 590, in load_config
    opts = _read_conf_file(path)
  File "/usr/lib/python2.6/site-packages/salt/config.py", line 515, in _read_conf_file
    with salt.utils.fopen(path, 'r') as conf_file:
  File "/usr/lib/python2.6/site-packages/salt/utils/__init__.py", line 1068, in fopen
    fhandle = open(*args, **kwargs)
IOError: [Errno 21] Is a directory: '/var/data/services/jenkins/.salt'
Traceback (most recent call last):
  File "/usr/bin/salt", line 10, in <module>
    salt_main()
  File "/usr/lib/python2.6/site-packages/salt/scripts.py", line 135, in salt_main
    client.run()
  File "/usr/lib/python2.6/site-packages/salt/cli/__init__.py", line 56, in run
    local = salt.client.LocalClient(self.get_config_file_path())
  File "/usr/lib/python2.6/site-packages/salt/client/__init__.py", line 110, in __init__
    self.opts = salt.config.client_config(c_path)
  File "/usr/lib/python2.6/site-packages/salt/config.py", line 1994, in client_config
    os.path.expanduser('~/.salt')
  File "/usr/lib/python2.6/site-packages/salt/config.py", line 590, in load_config
    opts = _read_conf_file(path)
  File "/usr/lib/python2.6/site-packages/salt/config.py", line 515, in _read_conf_file
    with salt.utils.fopen(path, 'r') as conf_file:
  File "/usr/lib/python2.6/site-packages/salt/utils/__init__.py", line 1068, in fopen
    fhandle = open(*args, **kwargs)
IOError: [Errno 21] Is a directory: '/var/data/services/jenkins/.salt'

After that, the directory /var/data/services/jenkins/.salt is created and the file master.log in it. Running salt again, exit 2 and:

Usage: salt [options] '<target>' <function> [arguments]

salt: error: Failed to load configuration: [Errno 21] Is a directory: '/var/data/services/jenkins/.salt'

The environment:

           Salt: 2014.1.4
         Python: 2.6.9 (unknown, Mar 28 2014, 00:06:37)
         Jinja2: 2.6
       M2Crypto: 0.20.2
 msgpack-python: 0.1.13
   msgpack-pure: Not Installed
       pycrypto: 2.6.1
         PyYAML: 3.10
          PyZMQ: 2.2.0.1
            ZMQ: 3.2.4

[victormuse]

P.S. Downgrading to 2014.1.3 fixes this issue.

[terminalmage]

I've confirmed this by looking at the code. Thanks for the report, we'll get this sorted.

[terminalmage]

This is fixed in develop, via 6ab1bca. I've just pushed that commit to the 2014.1 branch to ensure that the fix will be in 2014.1.5.

[terminalmage]

Would you be able to test with the modification from that commit?

[terminalmage]

This appears to be a duplicate of #12169

[victormuse]

Yes, the patch at 6ab1bca fixes the issue. Thanks.

[terminalmage]

Great, thanks for confirming!

[Jlaird]

In case someone does not want to roll back you can remove the .salt folder and replace it with an empty .salt file. That fixes it on salt-master-2014.1.4-1.el6.noarch for me.