Chocolatey.bat doesn't exist in 0.9.8.24

[Sacro]

Although we've covered the move to c:\ProgramData\Chocolatey, the batch file that Salt looks for is no longer provided.

Salt needs to support chocolatey.cmd in both folders also.

[basepi]

Thanks for the report.

[Sacro]

This need looking into rather soon, chocolatey is no longer working under salt otherwise :(

[basepi]

Ah, good point! I'll mark this as a bug instead of a feature. I wasn't paying very close attention when I originally triaged this one.

[Sacro]

That will work for people running 0.8.23 and below in c:\chocolatey and people running 0.8.24 in c:\ProgramData\Chocolatey

[ghost]

Test Failed.

If the failures are unrelated to your code, don't stress, a core developer will know these apart.
In the future, if possible, please branch off a passing commit to avoid false positives.
Refer to this link for build results: http://jenkins.saltstack.com/job/salt-pr-build/5787/

[ghost]

Test Failed.

If the failures are unrelated to your code, don't stress, a core developer will know these apart.
In the future, if possible, please branch off a passing commit to avoid false positives.
Refer to this link for build results: http://jenkins.saltstack.com/job/salt-pr-build/5807/

[thatch45]

Thanks for the catch @Sacro !!

[basepi]

So I swear Github is playing tricks on me, I'm not sure why I triaged this as an issue rather than a pull request. Looking back at the e-mail that Github sent me, it has none of the regular things that a pull request has, like the commit summary and whatnot. Weird.

Anyway, thanks for the addition, @Sacro. And the merge, @thatch45.

[basepi]

@Sacro Did you convert this issue to a pull request using the API? Similar this this? http://opensoul.org/2012/11/09/convert-a-github-issue-into-a-pull-request/

Would explain my utter confusion as to how I managed to triage it as an issue, and would also explain why a pull request could be open for 6 days before getting a reply from Tom.

[Sacro]

Yes @basepi I used the 'hub' application. you didn't have a pull request for 6 days, I only sent that in yesterday. I'm a bit of a newbie to Git so I might have made a faux pas!

[basepi]

Hehe, I was just super confused, I triage and label issues but not pull requests.

In the future, I would recommend creating a separate pull request, and just linking to the issue in question. Keeps things cleaner, IMO.

[basepi]

This does not apply cleanly to the 2014.1 branch, and since I'm not familiar with the code, I'm not going to cherry-pick it and risk breaking it.

[Sacro]

It should apply cleanly if you apply UtahDave@b024c9f first

[Sacro]

From issue - #13356

[basepi]

@Sacro it did indeed, thanks!