Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reload_modules argument doesn't reload grains #15125

Closed
ryan-lane opened this issue Aug 20, 2014 · 7 comments
Closed

reload_modules argument doesn't reload grains #15125

ryan-lane opened this issue Aug 20, 2014 · 7 comments
Labels
Bug broken, incorrect, or confusing behavior fixed-pls-verify fix is linked, bug author to confirm fix severity-low 4th level, cosemtic problems, work around exists
Milestone
Approved

Comments

@ryan-lane
Copy link
Contributor

Though reload_modules will reload the grain modules, it doesn't reload grains. So, if I update my hostname in a state, then wish to use the fqdn grain later in the same state run, it'll have the incorrect FQDN. Additionally, if I install a python module necessary for a grain module, grains for that run will also not be loaded.
This was referenced Aug 20, 2014
Closed
Merged
@ryan-lane
Copy link
Contributor Author

Fixed and verified.

@ryan-lane
Copy link
Contributor Author

Fix was reverted in #15157.

@ryan-lane ryan-lane reopened this Aug 21, 2014
@cachedout cachedout added this to the Approved milestone Aug 22, 2014
@ryan-lane
Copy link
Contributor Author

Rather than reloading the grains whenever modules are reloaded, maybe we could have another reload_grains keyword that can be used? In the case where both modules and grains need to be reloaded, both keywords could be used.

@basepi
Copy link
Contributor

basepi commented Sep 12, 2014

Seems like a reasonable solution to me.

@ryan-lane
Copy link
Contributor Author

Trying again with #18351

@jfindlay jfindlay added the fixed-pls-verify fix is linked, bug author to confirm fix label Nov 21, 2014
@jfindlay
Copy link
Contributor

@ryan-lane, same for this one as #18352 (comment)

@ryan-lane
Copy link
Contributor Author

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug broken, incorrect, or confusing behavior fixed-pls-verify fix is linked, bug author to confirm fix severity-low 4th level, cosemtic problems, work around exists
Projects
None yet
Milestone
Approved
Development

No branches or pull requests
4 participants
@cachedout @basepi @jfindlay @ryan-lane