Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

boto_elb's doesn't call boto_route53 state, which leads to route53 failures #23034

Closed
ryan-lane opened this issue Apr 24, 2015 · 2 comments
Closed

boto_elb's doesn't call boto_route53 state, which leads to route53 failures #23034

ryan-lane opened this issue Apr 24, 2015 · 2 comments
Labels
Bug broken, incorrect, or confusing behavior Execution-Module fixed-pls-verify fix is linked, bug author to confirm fix P3 Priority 3 severity-medium 3rd level, incorrect or bad functionality, confusing and lacks a work around
Milestone
Approved

Comments

@ryan-lane
Copy link
Contributor

boto_elb can manage cnames for elbs, but when I initially wrote this, I didn't make a call out the the boto_route53 state module, but reimplemented a lot of the logic. So, the boto_elb state now suffers the same issue as #18720. We should use boto_asg as an example (which calls out to the boto_lc state module), and have boto_elb call the boto_route53 state module, which already has a fix to this issue.
@jfindlay jfindlay added Bug broken, incorrect, or confusing behavior severity-medium 3rd level, incorrect or bad functionality, confusing and lacks a work around Salt-Cloud P3 Priority 3 labels Apr 24, 2015
@jfindlay
Copy link
Contributor

@ryan-lane, thanks for the report. We should definitely do this.

@rallytime rallytime added this to the Approved milestone Apr 24, 2015
@Reiner030 Reiner030 mentioned this issue May 5, 2015
Closed
@ryan-lane
Copy link
Contributor Author

fixed in #24199

@rallytime rallytime added the fixed-pls-verify fix is linked, bug author to confirm fix label May 28, 2015
@jfindlay jfindlay mentioned this issue May 28, 2015
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug broken, incorrect, or confusing behavior Execution-Module fixed-pls-verify fix is linked, bug author to confirm fix P3 Priority 3 severity-medium 3rd level, incorrect or bad functionality, confusing and lacks a work around
Projects
None yet
Milestone
Approved
Development

No branches or pull requests
3 participants
@jfindlay @ryan-lane @rallytime