Ubuntu service.running enabled broken in latest release

[joshughes]

v2014.7.5 of salt on Ubuntu 14.04 the following works

elasticsearch:
  service:
    - running
    - enable: True

With the latest 'stable' release (v2015.5.0) my serverspec tests fail because there is no startup entry created.

I confirmed the issue by restarting my machine and seeing that the elasticsearch service was not started on boot up.

After downgrading to v2014.7.5 the enabled: True flag works, the serverspec tests pass and on reboot elasticsearch starts.

[lorengordon]

The 'latest' version available to a distro sometimes varies... Specifically which version experienced the problem? I saw there were a few changes to the enable function that went into the develop branch only, and another pr was just merged yesterday into the 2015.5 branch. Far as I can tell, I don't think any of that has made it into an actual release, yet, though...

[joshughes]

@lorengordon I was on 'stable' not latest. At least that is what I am passing to the salt boostrap script... Let me get the exact version.

[lorengordon]

You can just copy-paste the output of salt-call --versions-report to provide the version of salt and its dependencies.

[joshughes]

@lorengordon

vagrant@vagrant-ubuntu-trusty-64:~$ salt-call  --version
salt-call 2015.5.0 (Lithium)

[joshughes]

I an confirm that v2015.5.0 does not work and v2014.7.5 does. This is running on Ubuntu 14.04.

[tbaker57]

This might be a duplicate of #24012, which has now been closed/fixed.
cheers,
Tim

[lorengordon]

Ahh, I think you're right @tbaker57. That fix was only merged into develop though and doesn't appear to have been backported to 2015.5. In the associated PR, it also seems that @jfindlay had some concerns that reverting the earlier commit would simply re-introduce the behavior that it was trying to fix...perhaps there's another patch in the works?

[jfindlay]

I'm not sure which solution is correct, or if a 3rd is needed, without spending some more time on this. If anyone else has information, you are welcome to include it here, thanks.

[kiorky]

@lorengordon i made recently two loads of fixes for enable/disable which were merged onto 2015.5 but i doubt for them to have hit any releases.

If you are touching to ubuntu vivid (>= 15.04), you also need #23060

cc @basepi @joshughes

[rallytime]

It looks to me like perhaps the fix that is marked for backporting may be fixing more problems than the original fix was attempting to solve. I am going to backport the fix from develop to 2015.5 for now, and if that original issue pops up again, then we can address this again. See #24345.

[meggiebot]

Closing per the above comment ^