salt.modules.smartos_* limit to global zone only #25982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
pinging @mguegan |
|
Hi @sjorge, I'm not sure why are you pinging me (as I can't merge this patch) but anyway it seems totally legit. |
|
@mguegan I pinged you since you were the original developer of smartos_imgadm/smartos_vmadm. |
|
Yes, sure, but I don't know what can I do to help you ? |
|
Just a sanity check (as you already did :)) as I do not know the full history of these modules, there may have been something I over looked that this would break. (But seems fine in my few tests) |
|
Ok, thanks for your explanation ! I can't see any drawbacks : imgadm and vmadm are indeed only used inside the GZ. |
cachedout
pushed a commit
that referenced
this pull request
Aug 4, 2015
salt.modules.smartos_* limit to global zone only
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
smartos_vmadm and smartos_imgadm does not make sense if we are not inside a smartos global zone.
using recently added is_smartos_global zone to check if we are good to go.