Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Salt 2015.8 does not sign the security token when it is used #26360

Closed
TronPaul opened this issue Aug 16, 2015 · 5 comments
Closed

Salt 2015.8 does not sign the security token when it is used #26360

TronPaul opened this issue Aug 16, 2015 · 5 comments
Labels
Bug broken, incorrect, or confusing behavior fixed-pls-verify fix is linked, bug author to confirm fix P2 Priority 2 RIoT Relates to integration with cloud providers, hypervisors, API-based services, etc. severity-medium 3rd level, incorrect or bad functionality, confusing and lacks a work around
Milestone
Approved

Comments

@TronPaul
Copy link
Contributor

Salt Version: 2015.8.0rc3-48-gacf450e
I must have screwed up my testing. The security token header is sent, but when using the security token it seems you only need to send and sign the security token for access.
@TronPaul
Copy link
Contributor Author

I'm trying to parse the docs but they're pretty opaque regarding the temporary security token.

@TronPaul TronPaul changed the title Salt 2015.8 does not send the correct headers using security tokens Salt 2015.8 does not sign the security token when it is used Aug 16, 2015
@TronPaul TronPaul mentioned this issue Aug 16, 2015
Merged
@rallytime
Copy link
Contributor

Thanks for this report and for submitting this fix @TronPaul. You're awesome!

Since you're fix was merged, is it ok to close this?

@rallytime rallytime added Bug broken, incorrect, or confusing behavior severity-medium 3rd level, incorrect or bad functionality, confusing and lacks a work around fixed-pls-verify fix is linked, bug author to confirm fix Salt-Cloud P2 Priority 2 RIoT Relates to integration with cloud providers, hypervisors, API-based services, etc. labels Aug 17, 2015
@rallytime rallytime added this to the Approved milestone Aug 17, 2015
@TronPaul
Copy link
Contributor Author

Yep, forgot to close it because I'm poking at another issue currently.

@TronPaul
Copy link
Contributor Author

Oh and as a clarification this is salt's fileclient (used for pillar and states). Not sure if that includes salt-cloud or not.

@rallytime
Copy link
Contributor

Oh, you're right that is a bit mis-labeled. I just saw aws and put that on there. thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug broken, incorrect, or confusing behavior fixed-pls-verify fix is linked, bug author to confirm fix P2 Priority 2 RIoT Relates to integration with cloud providers, hypervisors, API-based services, etc. severity-medium 3rd level, incorrect or bad functionality, confusing and lacks a work around
Projects
None yet
Milestone
Approved
Development

No branches or pull requests
2 participants
@TronPaul @rallytime