Provider overrides appear to be broken

[justinta]

On an ubuntu system I set the provider to yumpkg/yumpkg5 and was still able to install packages. This should cause a stack trace.
@terminalmage @basepi

Output below shows yumpkg5 as the provider, the minion restarted, what os is running, and htop being installed.

root@li162-102:~# cat /etc/salt/minion | grep -A 2 providers
# via the providers option, in this case the default module will be
# overwritten by the specified module. In this example the pkg module will
# be provided by the yumpkg5 module instead of the system default.
#providers:
#  pkg: yumpkg5
providers:
  pkg: yumpkg5
#
root@li162-102:~# service salt-minion restart
salt-minion stop/waiting
salt-minion start/running, process 8718
root@li162-102:~# salt '*' grains.get os
li162-102.members.linode.com:
    Ubuntu
root@li162-102:~# salt '*' pkg.install htop
li162-102.members.linode.com:
    ----------
    htop:
        ----------
        new:
            1.0.2-3
        old:

[justinta]

#26994

[basepi]

I also think based on some customer testing that even in cases where it tries to override, it's not packing __salt__ and other values properly in the overridden provider. I'll be looking into this this week.

[meggiebot]

ZD 416

[basepi]

Fixed in #27388