Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Starting a glusterfs volume after creation fails with an exception in 2015.8 and after. #30923

Closed
youngnick opened this issue Feb 5, 2016 · 1 comment
Labels
Bug broken, incorrect, or confusing behavior Execution-Module P2 Priority 2 Platform Relates to OS, containers, platform-based utilities like FS, system based apps severity-medium 3rd level, incorrect or bad functionality, confusing and lacks a work around
Milestone

Comments

@youngnick
Copy link

Looks like when the module got changed to use the _gluster_xml function, the start command was missed; using create now with start: True will raise an exception.

From a debug run on the minion involved:

[INFO    ] Executing command 'gluster --xml --mode=script' in directory '/root'
[ERROR   ] Command 'gluster --xml --mode=script' failed with return code: 1
[ERROR   ] output: unrecognized word: gluster (position 0)
[ERROR   ] An exception occurred in this state: Traceback (most recent call last):
  File "/usr/lib/python2.7/dist-packages/salt/state.py", line 1624, in call
    **cdata['kwargs'])
  File "/usr/lib/python2.7/dist-packages/salt/loader.py", line 1491, in wrapper
    return f(*args, **kwargs)
  File "/usr/lib/python2.7/dist-packages/salt/states/glusterfs.py", line 156, in created
    transport, start, force)
  File "/usr/lib/python2.7/dist-packages/salt/modules/glusterfs.py", line 247, in create
    _gluster_xml('gluster volume start {0}'.format(name))
  File "/usr/lib/python2.7/dist-packages/salt/modules/glusterfs.py", line 64, in _gluster_xml
    ).replace("\n", ""))
  File "/usr/lib/python2.7/xml/etree/ElementTree.py", line 1300, in XML
    parser.feed(text)
  File "/usr/lib/python2.7/xml/etree/ElementTree.py", line 1642, in feed
    self._raiseerror(v)
  File "/usr/lib/python2.7/xml/etree/ElementTree.py", line 1506, in _raiseerror
    raise err
ParseError: syntax error: line 1, column 0

I have a PR for this, it's a trivial change.

@jfindlay jfindlay added Execution-Module Bug broken, incorrect, or confusing behavior severity-medium 3rd level, incorrect or bad functionality, confusing and lacks a work around P2 Priority 2 Platform Relates to OS, containers, platform-based utilities like FS, system based apps labels Feb 5, 2016
@jfindlay jfindlay added this to the Approved milestone Feb 5, 2016
@jfindlay
Copy link
Contributor

jfindlay commented Feb 5, 2016

@youngnick, thanks for fixing this.

@jfindlay jfindlay closed this as completed Feb 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug broken, incorrect, or confusing behavior Execution-Module P2 Priority 2 Platform Relates to OS, containers, platform-based utilities like FS, system based apps severity-medium 3rd level, incorrect or bad functionality, confusing and lacks a work around
Projects
None yet
Development

No branches or pull requests

2 participants