Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2016.3.0 REGRESSION windows rename of minion during re-install doesn't take #33783

Closed
TheBigBear opened this issue Jun 5, 2016 · 1 comment
Closed
Assignees
Labels
Bug broken, incorrect, or confusing behavior fixed-pls-verify fix is linked, bug author to confirm fix P2 Priority 2 severity-medium 3rd level, incorrect or bad functionality, confusing and lacks a work around Windows
Milestone

Comments

@TheBigBear
Copy link
Contributor

TheBigBear commented Jun 5, 2016

Description of Issue/Question

if you try to rename an existing windows minion during re-install the new name does not take.
the windows minion keeps the old name, now new keys get sent to the master and on another re-install it is evidently back to the original old name we tried renaming it away from.

Setup

on a windows minion with same or earlier version of salt-minion installed and running, download the latest 2016.3 salt-minon installer. start a re-install and click to OK about it already being installed, then on the second prompt change to a new and different minion name. continue and accept the run the service prompt at end of install.
nothing changes on master (or on the minion) if you do another re-install it will show the old original minion name again. this definitely used to work, it used it a lot on 2015.8.10 and earlier .

@ssgward ssgward added Bug broken, incorrect, or confusing behavior severity-medium 3rd level, incorrect or bad functionality, confusing and lacks a work around Windows P2 Priority 2 labels Jun 6, 2016
@ssgward ssgward added this to the Approved milestone Jun 6, 2016
@twangboy twangboy modified the milestones: C 8, Approved Jun 6, 2016
@twangboy
Copy link
Contributor

The above PRs should fix this issue.

@rallytime rallytime added the fixed-pls-verify fix is linked, bug author to confirm fix label Jun 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug broken, incorrect, or confusing behavior fixed-pls-verify fix is linked, bug author to confirm fix P2 Priority 2 severity-medium 3rd level, incorrect or bad functionality, confusing and lacks a work around Windows
Projects
None yet
Development

No branches or pull requests

5 participants