add log-rotate function on windows

[derek0377]

linux can rotate log easily, windows not,so would you support rotate log?
I see code:
https://github.com/saltstack/salt/blob/develop/salt/log/setup.py#L639
function setup_logfile_logger:
handler = WatchedFileHandler(log_path, mode='a', encoding='utf-8', delay=0)

if config logrotate, then change to:
handler = RotatingFileHandler(log_path, maxBytes=config.maxBytes,backupCount=configy.backupCount) that will work as I do on my own environment.

Other need is adding that code and add conf in config.py,
That really helps a lot on windows platform as log-rotate is hard on windows-self.
So would you support it? Thanks

[Ch3LL]

ping @twangboy do you think it would be possible to implement something like this?

[twangboy]

@Ch3LL Is this a feature. Does Linux handle the logs automatically? How would this affect Linux?

[damon-atkins]

#26195 See this thread started in 2015 this is a duplicate

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

If this issue is closed prematurely, please leave a comment and we will gladly reopen the issue.

[marbx]

I need this feature.

[marbx]

Pleasse reopen and suggest a solution. Thank you

[twangboy]

I think this is handled for Salt logs with log_rotate_max_bytes and log_rotate_backup_count
https://docs.saltstack.com/en/latest/ref/configuration/minion.html#log-rotate-max-bytes

Unless you're talking about the actual Windows logs...

[marbx]

Thank you - these settings would be a solution.

Only that on a 2016.11.3 minion, from these 3 settings only the level takes effect:
log_level_logfile: debug
log_rotate_max_bytes: 1200
log_rotate_backup_count: 3

[twangboy]

Looks like those options were added in 2017.7.

[marbx]

On a 2018.3.3 client: very nice log file rotation :-)