Returns the redis error

[ypoison]

Description of Issue/Question

Returns the redis error

Setup

$/etc/salt/master
master_job_cache: redis

Steps to Reproduce Issue

File "/data/apps/python2.7/lib/python2.7/site-packages/salt/utils/process.py", line 616, in _run
return self._original_run()
File "/data/apps/python2.7/lib/python2.7/site-packages/salt/master.py", line 237, in run
salt.daemons.masterapi.clean_old_jobs(self.opts)
File "/data/apps/python2.7/lib/python2.7/site-packages/salt/daemons/masterapi.py", line 187, in clean_old_jobs
mminion.returnersfstr
File "/data/apps/python2.7/lib/python2.7/site-packages/salt/returners/redis_return.py", line 217, in clean_old_jobs
serv.delete(*to_remove) # pylint: disable=E1134
TypeError: delete() argument after * must be a mapping, not list

Versions Report

Salt Version:
Salt: 2016.3.3

Dependency Versions:
cffi: Not Installed
cherrypy: 3.8.0
dateutil: 2.5.3
gitdb: Not Installed
gitpython: Not Installed
ioflo: Not Installed
Jinja2: 2.8
libgit2: Not Installed
libnacl: Not Installed
M2Crypto: Not Installed
Mako: Not Installed
msgpack-pure: Not Installed
msgpack-python: 0.4.7
mysql-python: 1.2.3
pycparser: Not Installed
pycrypto: 2.6.1
pygit2: Not Installed
Python: 2.7.6 (default, Mar 21 2016, 16:12:03)
python-gnupg: Not Installed
PyYAML: 3.10
PyZMQ: 15.2.0
RAET: Not Installed
smmap: Not Installed
timelib: Not Installed
Tornado: 4.3
ZMQ: 4.1.2

System Versions:
dist: centos 6.8 Final
machine: x86_64
release: 2.6.32-642.1.1.el6.x86_64
system: Linux
version: CentOS 6.8 Final

[Ch3LL]

@ypoison I believe this is fixed by this pr #33998 but needs to be backported to 2016.3. I will look into getting that backported and in the meantime can you go ahead and see if that fixes your issue until we can get this in the next release? Thanks

[rallytime]

@ypoison and @Ch3LL The fix in #33998 has been back-ported to the 2016.3 branch in #36014.

[ypoison]

@Ch3LL The problem has been solved, thank you, but there is a redis return error is about #35016

line: 131
old:
def save_minions(jid, minions): # pylint: disable=unused-argument
new:
def save_minions(jid, minions, syndic_id=None): # pylint: disable=unused-argument

Want to fix it, thank you！

[Ch3LL]

@ypoison did you want to submit a PR with that fix? Does that resolve that new error you are seeing?