Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2016.3.4: Windows minion does not kill process running in foreground #37192

Closed
Ch3LL opened this issue Oct 24, 2016 · 4 comments
Closed

2016.3.4: Windows minion does not kill process running in foreground #37192

Ch3LL opened this issue Oct 24, 2016 · 4 comments
Assignees
Labels
Bug broken, incorrect, or confusing behavior P3 Priority 3 Platform Relates to OS, containers, platform-based utilities like FS, system based apps Regression The issue is a bug that breaks functionality known to work in previous releases. severity-critical top severity, seen by most users, serious issues severity-high 2nd top severity, seen by most users, causes major problems Windows ZRELEASED - 2016.3.4
Milestone

Comments

@Ch3LL
Copy link
Contributor

Ch3LL commented Oct 24, 2016

Description of Issue/Question

When running ./salt-minion.bat -ldebug on a windows minion in powershell when I attempt to kill the process with Ctrl + c It does not bring me down to another prompt and just hangs there.

Setup

  1. Install salt-minion on windows host. don't even need to attach it to a master can be a clean install

Steps to Reproduce Issue

  1. start the minion process by doing the following:
    • cd \salt
    • ./salt-minion.bat -ldebug
  2. Try selecting Ctrl + c and it will say the salt minion shutdown but you are never sent to a prompt to continue interacting with powershell. Here is the output:
[INFO    ] The Salt Minion is shut down
The salt minion is shutdown. Minion received a SIGINT. Exited.



And it just hangs there now matter how many times I select Ctrl + c. I have to close out the powershell prompt and open a new one.

On previous versions for example 2016.3.3 I would see the following:

[INFO    ] The Salt Minion is shut down
The salt minion is shutdown. Minion received a SIGINT. Exited. Terminate batch job (Y/N)?y
PS C:\salt> 

Versions Report

2016.3.4 windows 2012

@Ch3LL Ch3LL added Bug broken, incorrect, or confusing behavior Windows severity-high 2nd top severity, seen by most users, causes major problems P3 Priority 3 Platform Relates to OS, containers, platform-based utilities like FS, system based apps labels Oct 24, 2016
@Ch3LL Ch3LL added this to the Approved milestone Oct 24, 2016
@Ch3LL Ch3LL added Regression The issue is a bug that breaks functionality known to work in previous releases. ZRELEASED - 2016.3.5 severity-critical top severity, seen by most users, serious issues labels Oct 24, 2016
@meggiebot meggiebot modified the milestones: C 2, Approved Oct 25, 2016
@twangboy
Copy link
Contributor

twangboy commented Oct 25, 2016

Caused by: #36555

It's removing __MP_LOGGING_QUEUE_PROCESS.daemon = True that causes the problem.

@twangboy
Copy link
Contributor

Same thing happens from a cmd prompt as well

@cachedout
Copy link
Contributor

@DmitryKuzmenko Can you please comment on the above?

@DmitryKuzmenko
Copy link
Contributor

I confirm that removing the __MP_LOGGING_QUEUE_PROCESS.daemon = True causes the issue. But that line causes exceptions during shutdown because the logging queue daemon is attempting to be killed multiple times. I'm working on this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug broken, incorrect, or confusing behavior P3 Priority 3 Platform Relates to OS, containers, platform-based utilities like FS, system based apps Regression The issue is a bug that breaks functionality known to work in previous releases. severity-critical top severity, seen by most users, serious issues severity-high 2nd top severity, seen by most users, causes major problems Windows ZRELEASED - 2016.3.4
Projects
None yet
Development

No branches or pull requests

5 participants