Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nodegroups YAML list not working #40355

Closed
jirobulova opened this issue Mar 28, 2017 · 5 comments
Closed

Nodegroups YAML list not working #40355

jirobulova opened this issue Mar 28, 2017 · 5 comments
Assignees
Labels
expected-behavior intended functionality
Milestone

Comments

@jirobulova
Copy link

jirobulova commented Mar 28, 2017

Description of Issue/Question

Nodegroups YAML list not working https://docs.saltstack.com/en/latest/topics/targeting/nodegroups.html#defining-nodegroups-as-lists-of-minion-ids

Setup

/etc/salt/master

nodegroups:
  - group1:
    - s-intest-01
    - s-intest-02

Steps to Reproduce Issue

salt -N group1 test.ping
Node group group1 unavailable in /etc/salt/master

[salt.config ][WARNING ][15490] Key 'nodegroups' with value [{'group1': ['s-intest-01', 's-intest-02']}] has an invalid type of list, a dict is required for this value

Versions Report

Salt Version:
Salt: 2016.11.3

Dependency Versions:
cffi: Not Installed
cherrypy: Not Installed
dateutil: 2.4.2
gitdb: 0.6.4
gitpython: 1.0.1
ioflo: Not Installed
Jinja2: 2.8
libgit2: Not Installed
libnacl: Not Installed
M2Crypto: Not Installed
Mako: 1.0.3
msgpack-pure: Not Installed
msgpack-python: 0.4.6
mysql-python: Not Installed
pycparser: Not Installed
pycrypto: 2.6.1
pygit2: Not Installed
Python: 2.7.12 (default, Nov 19 2016, 06:48:10)
python-gnupg: Not Installed
PyYAML: 3.11
PyZMQ: 15.2.0
RAET: Not Installed
smmap: 0.9.0
timelib: Not Installed
Tornado: 4.2.1
ZMQ: 4.1.4

System Versions:
dist: Ubuntu 16.04 xenial
machine: x86_64
release: 4.4.0-59-generic
system: Linux
version: Ubuntu 16.04 xenial

@Ch3LL
Copy link
Contributor

Ch3LL commented Mar 28, 2017

Looks like i can replicate this @jirobulova . Here is a docker container for anyone that wants to quickly replicate the issue

  1. docker run -it -v /home/ch3ll/git/salt/:/testing/ ch3ll/issues:40355 (where /home/ch3ll/git/salt is a local cloned git repo of salt)
  2. salt-master -d; salt-minion -d
  3. salt -N group1 test.ping
    And you will see this warning:
[root@3d58625f762c /]# salt -N group1 test.ping
[WARNING ] Key 'nodegroups' with value [{'group1': ['test']}] has an invalid type of list, a dict is required for this value
[WARNING ] Key 'nodegroups' with value [{'group1': ['test']}] has an invalid type of list, a dict is required for this value
Node group group1 unavailable in /etc/salt/master
[root@3d58625f762c /]# 

ping @terminalmage looks like you added this ability here: #35065 are we missing something in our setup?

@Ch3LL Ch3LL added Bug broken, incorrect, or confusing behavior severity-medium 3rd level, incorrect or bad functionality, confusing and lacks a work around P4 Priority 4 Core relates to code central or existential to Salt labels Mar 28, 2017
@Ch3LL Ch3LL added this to the Approved milestone Mar 28, 2017
@terminalmage terminalmage added expected-behavior intended functionality and removed Bug broken, incorrect, or confusing behavior severity-medium 3rd level, incorrect or bad functionality, confusing and lacks a work around Core relates to code central or existential to Salt P4 Priority 4 labels Mar 29, 2017
@terminalmage
Copy link
Contributor

According to the nodegroups documentation, there should be no dash before each nodegroup name.

@terminalmage
Copy link
Contributor

I opened #40381 so that defining nodegroups as a yaml list of dicts (a.k.a. "dictlist") works. Many parts of Salt support this configuration schema (states, most notably), so it makes sense to have nodegroups also support it.

@terminalmage
Copy link
Contributor

@jirobulova were you able to try again with the correct configuration schema? I added support for the configuration schema you're using for the Nitrogen feature release.

@cachedout
Copy link
Contributor

Closing since there was no reply here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
expected-behavior intended functionality
Projects
None yet
Development

No branches or pull requests

4 participants