Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Race conditions in "data" module #41027

Closed
AndreiPashkin opened this issue May 3, 2017 · 3 comments
Closed

Race conditions in "data" module #41027

AndreiPashkin opened this issue May 3, 2017 · 3 comments
Labels
Core relates to code central or existential to Salt Feature new functionality including changes to functionality and code refactors, etc. stale
Milestone

Comments

@AndreiPashkin
Copy link
Contributor

Description of Issue/Question

I was reviewing the "data" module code and I discovered, that there is no handling of the race conditions as far as I can see:

if not isinstance(new_data, dict):

@gtmanfred
Copy link
Contributor

We would love a PR to add some locking on the data module.

Thanks,
Daniel

@gtmanfred gtmanfred added Core relates to code central or existential to Salt Feature new functionality including changes to functionality and code refactors, etc. labels May 3, 2017
@gtmanfred gtmanfred added this to the Approved milestone May 3, 2017
@AndreiPashkin
Copy link
Contributor Author

@gtmanfred, maybe it's better to use a database, like Berkley DB or SQLite?

@stale
Copy link

stale bot commented Oct 16, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

If this issue is closed prematurely, please leave a comment and we will gladly reopen the issue.

@stale stale bot added the stale label Oct 16, 2018
@stale stale bot closed this as completed Oct 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core relates to code central or existential to Salt Feature new functionality including changes to functionality and code refactors, etc. stale
Projects
None yet
Development

No branches or pull requests

2 participants