Scheduler with multiple when values doesn't run

[jonans]

Description of Issue/Question

If a schedule is defined with more than one "when" value is doesn't run reliably. It may do the 1st or 2nd item and the rest are ignored. Sometimes it doesn't run at all.

Setup

test-schedule:
  schedule.present:
    - function: log.critical
    - job_args:
      - Schedule Running
    - when:
      - Thu 09:18:00
      - Thu 09:18:10
      - Thu 09:18:20
      - Thu 09:18:30
      - Thu 09:18:40
      - Thu 09:18:50

Steps to Reproduce Issue

Try the above schedule with multiple items 10 seconds apart and watch the minion logs, it may or maynot run. We a have the need for a 28 item schedule but it never runs at all.

Versions Report

Salt Version:
           Salt: 2017.7.2
 
Dependency Versions:
           cffi: 1.5.2
       cherrypy: Not Installed
       dateutil: 2.4.2
      docker-py: Not Installed
          gitdb: 0.6.4
      gitpython: 1.0.1
          ioflo: Not Installed
         Jinja2: 2.8
        libgit2: 0.24.0
        libnacl: Not Installed
       M2Crypto: Not Installed
           Mako: 1.0.3
   msgpack-pure: Not Installed
 msgpack-python: 0.4.6
   mysql-python: Not Installed
      pycparser: 2.14
       pycrypto: 2.6.1
   pycryptodome: Not Installed
         pygit2: 0.24.0
         Python: 2.7.12 (default, Nov 19 2016, 06:48:10)
   python-gnupg: Not Installed
         PyYAML: 3.12
          PyZMQ: 15.2.0
           RAET: Not Installed
          smmap: 0.9.0
        timelib: Not Installed
        Tornado: 4.2.1
            ZMQ: 4.1.4
 
System Versions:
           dist: Ubuntu 16.04 xenial
         locale: UTF-8
        machine: x86_64
        release: 4.4.0-93-generic
         system: Linux
        version: Ubuntu 16.04 xenial

[Ch3LL]

I was able to repliacte this and it was working in 2016.11 branch so I git bisected it to this 905be49 which is this PR: #42107

Looks like we need to get this fixed thanks

[Ch3LL]

ping @jonans mind giving the fix in #44186 a try?

[jonans]

Yes problem fixed. Thanks.