Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SLS rendering errors could be more helpful #44501

Open
jdshewey opened this issue Nov 12, 2017 · 9 comments
Open

SLS rendering errors could be more helpful #44501

jdshewey opened this issue Nov 12, 2017 · 9 comments
Labels
Feature new functionality including changes to functionality and code refactors, etc. severity-low 4th level, cosemtic problems, work around exists
Milestone

Comments

@jdshewey
Copy link

Description of Issue/Question

When referencing a pillar that does not exist, an error is thrown such as:

Rendering SLS 'base:katello.server' failed: Jinja variable 'str object' has no attribute 'gpg_key' this error could be more helpful by including the line number of the SLS or the ID Declaration. This is particularly useful in large files where a variable like gpg_key could be referenced often and it is difficult to find the instance that was fat-fingered.

@gtmanfred gtmanfred added Feature new functionality including changes to functionality and code refactors, etc. severity-low 4th level, cosemtic problems, work around exists labels Nov 13, 2017
@gtmanfred gtmanfred added this to the Approved milestone Nov 13, 2017
@gtmanfred
Copy link
Contributor

Yeah, that seems reasonable, I am marking this as a feature request.

Thanks,
Daniel

@stale
Copy link

stale bot commented Mar 8, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

If this issue is closed prematurely, please leave a comment and we will gladly reopen the issue.

@stale stale bot added the stale label Mar 8, 2019
@jdshewey
Copy link
Author

jdshewey commented Mar 8, 2019

bump

@stale
Copy link

stale bot commented Mar 8, 2019

Thank you for updating this issue. It is no longer marked as stale.

@stale stale bot removed the stale label Mar 8, 2019
@helephant
Copy link

I'm also currently wishing for line numbers :)

I'm getting the somewhat baffling: "Trying to populate non string value into a string for variable ${deep:4}. Please make sure the value of the property is a string."

@driskell
Copy link
Contributor

I spend most of my hours finding errors in big SLS files. This is not so much a feature request but a big requirement.

@stale
Copy link

stale bot commented Jan 8, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

If this issue is closed prematurely, please leave a comment and we will gladly reopen the issue.

@stale stale bot added the stale label Jan 8, 2020
@jdshewey
Copy link
Author

jdshewey commented Jan 8, 2020

bump

@stale
Copy link

stale bot commented Jan 8, 2020

Thank you for updating this issue. It is no longer marked as stale.

@stale stale bot removed the stale label Jan 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature new functionality including changes to functionality and code refactors, etc. severity-low 4th level, cosemtic problems, work around exists
Projects
None yet
Development

No branches or pull requests

4 participants