salt.states.boto_elbv2 module needs updating to create / delete load balancers and listeners

[ac-hibbert]

Description of Issue/Question

Setup

N/A

Steps to Reproduce Issue

I was looking for a way to use salt to automate my AWS ELB setup. It seems that the full ELB state which creates load balancers etc is just for classic load balancers - https://docs.saltstack.com/en/develop/ref/states/all/salt.states.boto_elb.html. There is a new module for the new load balancers using boto3 elbv2 but it only supports creating target groups and registering targets and not the create_load_balancer and create_listener from boto3 elbv2, so unable to fully automate all current ELB types.

Versions Report

salt --versions-report

Salt Version:
Salt: 2017.7.2

Dependency Versions:
cffi: Not Installed
cherrypy: Not Installed
dateutil: 1.5
docker-py: 1.10.6
gitdb: Not Installed
gitpython: Not Installed
ioflo: Not Installed
Jinja2: 2.7.2
libgit2: Not Installed
libnacl: Not Installed
M2Crypto: Not Installed
Mako: Not Installed
msgpack-pure: Not Installed
msgpack-python: 0.4.8
mysql-python: 1.2.5
pycparser: Not Installed
pycrypto: 2.6.1
pycryptodome: Not Installed
pygit2: Not Installed
Python: 2.7.5 (default, Aug 4 2017, 00:39:18)
python-gnupg: Not Installed
PyYAML: 3.11
PyZMQ: 15.3.0
RAET: Not Installed
smmap: Not Installed
timelib: Not Installed
Tornado: 4.2.1
ZMQ: 4.1.4

System Versions:
dist: centos 7.4.1708 Core
locale: UTF-8
machine: x86_64
release: 3.10.0-693.2.2.el7.x86_64
system: Linux
version: CentOS Linux 7.4.1708 Core

[gtmanfred]

@team-boto can yall take a look at this?

Thanks,
Daniel

[rallytime]

@saltstack/team-boto ^

[ryan-lane]

boto_elb supports VPC and classic ELBs. You need to use subnets, rather than availability_zones for this.

boto_elbv2 is ALBs, not ELBs. boto_elbv2 will also support NLBs soon, but will never support classis or VPC ELBs, as those are v1 ELBs. This is an annoying naming scheme by AWS.

[ac-hibbert]

Yeah, boto_elb looks fine for a classic load balancer. I was looking to create an Application Load Balancer, but the boto_elbv2 saltstack state currently only creates the target group and registers instances, but there doesn't seem to be anything to create the load balancer and listeners to point at the target groups

[ryan-lane]

Ah. Gotcha. I think there's a couple companies working on elbv2 module right now (one of which is Lyft), which may be adding this functionality. Right now we're focused on NLBs, but I think a lot of the code overlaps between NLBs and ALBs.

[twellspring]

@ryan-lane was looking to restart my work on elbv2. Is Lyft still working on NLBs? Any ETA on a PR so I don't re-invent the wheel.

[Oloremo]

Same question as @twellspring - what is the status of the NLB implementation?

@saltstack/team-boto ?

[gtmanfred]

@saltstack/team-boto also, @saltstack/team-triage

[anitakrueger]

Any idea where this is at please? I had automated all our classic ELB creation with the boto_elb state and am now stuck because we're moving to application load balancers and I can't create them or the listeners via Salt, but only the target groups.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

If this issue is closed prematurely, please leave a comment and we will gladly reopen the issue.

[anitakrueger]

This is definitely not stale. No activity for 2 years, but the feature is still missing unfortunately.

[stale]

Thank you for updating this issue. It is no longer marked as stale.

[contherad]

Any update on this issue?

[anitakrueger]

@rallytime How do we get some traction on this? Any ideas? Thank you!

[cachedout]

@anitakrueger Hi Anita. Neither @rallytime (or myself) are with SaltStack anymore. I'll cc: @sagetherage who might be able to help route this to the proper person. Cheers. :)

[sagetherage]

@anitakrueger right now this feature isn't a priority for the Open Core team, but would look to @tkwilliams who is knowledgeable with this module or the community at large to submit a PR or ask for an architectural discussion with our Community Manager @cassandrafaris and key team members.

[anitakrueger]

@sagetherage thank you.

@cachedout Sorry, didn't realize you and @rallytime had left Saltstack. It's a bit difficult to know who to contact these days and who to tag on github issues. If only there was a Saltteam handle or something ;)

[sagetherage]

@anitakrueger you make a good point - there is a mention for the @saltstack/team-core but it may get lost there as well, we do have a community manager now so that should help, but for backlog items I would need to think about how we could make that workflow less about individuals. I open to suggestions in the meantime! :)

[cachedout]

@sagetherage FWIW, one of the hiccups with using @saltstack/team-core is that it is not discoverable from people outside the SaltStack organization. That means that normal features like GitHub autocomplete doesn't work and you need to specifically know what you're looking for in advance.

[sagetherage]

thx @cachedout yes, it has flaws for sure, a part from knowing the individual I am not sure on this ATM, but yes open to other ideas. We are working to update the Contributing.rst and docs, perhaps we need something specific there, but that is only a half-baked idea.