A proposal for modularizing tgt logic.

[kstreee]

Description of Issue/Question

In my company, we have used customized tgt modules by implementing company dependent methods. We would like to modularize the tgt module to maintain well (like auth modules), but the current tgt modules are implemented as a series of functions in a single file, /salt/utils/minions.py. Thus, if you guys think that this proposal—modularize tgt modules—is appropriate to Salt Stack, we would like to contribute it. I guess the auth module is a good reference for this modularization work.

Are there any opinions or questions about it, or any advice about modularizing tgt modules, please leave comments for us.

Thanks.

Setup

N/A

Steps to Reproduce Issue

N/A

Versions Report

N/A

[Ch3LL]

I don't see an issue with this idea but maybe @saltstack/team-core has some advice or opinions on this.

[kstreee]

@saltstack/team-core @Ch3LL Hi all, any opinions or advice here?

[thatch45]

I think this would be a fine idea.

If you want to implement this you would need to make a loader system, first take a look at the /salt/loader.py file. This file has a number of functions that invoke the loader to create the subsystems. Next you will need to make that loader instance where the Matcher class is created.

Now, the trick is that you will also need to modularize the CkMinions system as well, check all of those references and make sure they are also making loader calls. The CkMinions system is found here: https://github.com/saltstack/salt/blob/develop/salt/utils/minions.py#L174

[kstreee]

@thatch45 Thanks for the comment. It will be a great help for us while implementing it. Thanks 😄

[thatch45]

Feel free to reach out and ask questions. Adding a loader subsystem is not hard, but it can have a few confusing turns

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

If this issue is closed prematurely, please leave a comment and we will gladly reopen the issue.

[gtmanfred]

this was actually completed for 2019.2

they are located in salt/matchers