PostgreSQL - granting privileges to all functions in schema not supported

[jehlert]

Description of Issue/Question

It's appropriate in PostgreSQL to grant privileges to all functions within a schema. PostgreSQL syntax - GRANT EXECUTE ON ALL FUNCTIONS IN SCHEMA <schema_name> to <role_name>; This currently is not support in the postgresql module

When doing it via salt, the following is produced - GRANT EXECUTE ON FUNCTION ALL IN SCHEMA <schema_name> TO <role_name>.

Here is the line in the PostgreSQL module - https://github.com/saltstack/salt/blob/develop/salt/modules/postgres.py#L2947
Not sure why functions are handled differently than table and sequences.

Setup

Example:

postgres:
  groups:
    - name: my_role
      db: test_db
      privileges:
        - resource: ALL
          type: function
          prepend: test_schema
          privs:
            - EXECUTE

Steps to Reproduce Issue

Versions Report

Salt Version:
Salt: 2018.3.2

Dependency Versions:
cffi: 1.11.2
cherrypy: unknown
dateutil: 2.7.2
docker-py: Not Installed
gitdb: Not Installed
gitpython: Not Installed
ioflo: Not Installed
Jinja2: 2.10
libgit2: Not Installed
libnacl: Not Installed
M2Crypto: Not Installed
Mako: Not Installed
msgpack-pure: Not Installed
msgpack-python: 0.5.1
mysql-python: Not Installed
pycparser: 2.18
pycrypto: 2.6.1
pycryptodome: Not Installed
pygit2: Not Installed
Python: 2.7.5 (default, Apr 11 2018, 07:36:10)
python-gnupg: Not Installed
PyYAML: 3.12
PyZMQ: 15.3.0
RAET: Not Installed
smmap: Not Installed
timelib: Not Installed
Tornado: 4.2.1
ZMQ: 4.1.5

System Versions:
dist: centos 7.5.1804 Core
locale: UTF-8
machine: x86_64
release: 3.10.0-862.3.2.el7.x86_64
system: Linux
version: CentOS Linux 7.5.1804 Core

[Ch3LL]

looks like we just need to add the ability to do this for functions as well. Also the ability to add ALL to tables and sequences was added here: #36280 just as an fyi for whoever tackles this issue.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

If this issue is closed prematurely, please leave a comment and we will gladly reopen the issue.

[anitakrueger]

This is still a problem...

[stale]

Thank you for updating this issue. It is no longer marked as stale.

[maxammann]

Still a problem :)

[eriko]

Still as problem