Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: WinRM as a backup file transfer option in case smb is disabled #50889

Open
whytewolf opened this issue Dec 17, 2018 · 5 comments
Labels
Feature new functionality including changes to functionality and code refactors, etc. Windows ZD The issue is related to a Zendesk customer support ticket.
Milestone

Comments

@whytewolf
Copy link
Contributor

Description of Issue/Question

Currently, the WinRM offerings for Saltify and Cloud use SMB to transfer files. It would be good if there were an option to enable WinRM as a fall back option in case SMB is not available on the network. This would allow a wider range of accessibility for the WinRM offerings.

Yes, WinRM is a slower protocol. But some environments do block SMB traffic And this would allow those environments to still use the Saltify and Cloud options.

@whytewolf whytewolf added the ZD The issue is related to a Zendesk customer support ticket. label Dec 17, 2018
@whytewolf
Copy link
Contributor Author

ZD-3083

@garethgreenaway garethgreenaway added the Feature new functionality including changes to functionality and code refactors, etc. label Dec 18, 2018
@garethgreenaway garethgreenaway added this to the Approved milestone Dec 18, 2018
@KChandrashekhar KChandrashekhar added this to Consideration Set in Neon Feb 5, 2019
@arizvisa
Copy link
Contributor

As this feature is scheduled for implementation, another related feature (which likely resulted in this request) would be to support the preflight_cmds against Windows hosts as it's not implemented by salt.utils.deploy_windows.

This way a user can execute commands prior to deploying the minion binary namely to disable to firewall and actually enable SMB via something like: netsh advfirewall firewall set rule name="File and Printer Sharing (SMB-In)" new enable=yes, or Enable-NetFirewallRule -Name "FPS-SMB-In-TCP".

Although you're only copying a file once so performance might not be too important, http://github.com/hashicorp/packer has had issues with winrm file-transfer performance for quite a while and similarly pywinrm has had an issue reported with regards the file copy performance at diyan/pywinrm#77.

@stale
Copy link

stale bot commented Jan 7, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

If this issue is closed prematurely, please leave a comment and we will gladly reopen the issue.

@stale stale bot added the stale label Jan 7, 2020
@arizvisa
Copy link
Contributor

arizvisa commented Jan 7, 2020

This issue should probably be left open as it is being considered.

@stale
Copy link

stale bot commented Jan 7, 2020

Thank you for updating this issue. It is no longer marked as stale.

@stale stale bot removed the stale label Jan 7, 2020
@sagetherage sagetherage removed this from Backlog in Neon Jan 24, 2020
@sagetherage sagetherage added this to Considering in Sodium Jan 24, 2020
@sagetherage sagetherage removed this from Considering in Sodium Apr 24, 2020
@xeacott xeacott added this to To do in Windows Jan 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature new functionality including changes to functionality and code refactors, etc. Windows ZD The issue is related to a Zendesk customer support ticket.
Projects
Windows
  
To do
Magnesium
  
Awaiting triage
Development

No branches or pull requests

5 participants