Unable to use salt-formula with saltenvs

[bluemalkin]

Description of Issue/Question

I'm unable to use salt-formulas in my salt environments.

Setup

cat /etc/salt/master
timeout: 120
autosign_file: /etc/salt/autosign.conf
file_roots:
  base:
    - /srv/salt
  ops:
    - /srv/salt/ops
  dev:
    - /srv/salt/dev
  stg:
    - /srv/salt/stg
  prd:
    - /srv/salt/prd
fileserver_backend:
  - gitfs
  - roots
gitfs_provider: gitpython
#gitfs_update_interval: 60
gitfs_remotes:
  - https://github.com/salt-formulas/salt-formula-nginx.git:
    - all_saltenvs: master

state_verbose: False
auto_accept: False
top_file_merging_strategy: merge_all

Steps to Reproduce Issue

salt xx.opsxx' state.apply test=True
xx.ops.xx:
    Data failed to compile:
----------
    Specified SLS nginx in saltenv ops is not available on the salt master or through a configured fileserver

Versions Report

 salt --versions-report
Salt Version:
           Salt: 2018.3.3

Dependency Versions:
           cffi: 1.11.5
       cherrypy: Not Installed
       dateutil: 2.4.2
      docker-py: 1.10.6
          gitdb: 0.6.4
      gitpython: 1.0.1
          ioflo: Not Installed
         Jinja2: 2.8
        libgit2: 0.24.0
        libnacl: Not Installed
       M2Crypto: Not Installed
           Mako: 1.0.3
   msgpack-pure: Not Installed
 msgpack-python: 0.4.6
   mysql-python: Not Installed
      pycparser: 2.14
       pycrypto: 2.6.1
   pycryptodome: Not Installed
         pygit2: 0.24.0
         Python: 2.7.12 (default, Nov 12 2018, 14:36:49)
   python-gnupg: 0.3.8
         PyYAML: 3.11
          PyZMQ: 15.2.0
           RAET: Not Installed
          smmap: 0.9.0
        timelib: Not Installed
        Tornado: 4.2.1
            ZMQ: 4.1.4

System Versions:
           dist: Ubuntu 16.04 xenial
         locale: UTF-8
        machine: x86_64
        release: 4.4.0-78-generic
         system: Linux
        version: Ubuntu 16.04 xenial

[garethgreenaway]

@saltstack/team-core Anyone have any thoughts on this one?

[waynew]

@bluemalkin thanks for the report! I'm guessing you have done this already, but did you restart your salt master after changing the config?

[bluemalkin]

@waynew yes I have many times - thanks

[waynew]

@bluemalkin Just checking the easiest and most obvious problems first 😂

If you check your logs is there anything you can see around git - maybe not being available or something? I don't think that's the case, but I would like to at least rule it out as the cause.

[bluemalkin]

@waynew the only log we get is apparently an error we can ignore:

2019-02-25 22:44:51,020 [salt.loader      :1698][ERROR   ][26717] Failed to load function {'cmd': '_file_envs.envs because its module ({'cmd': '_file_envs) is not in the whitelist: [u'gitfs', u'roots']
2019-02-26 15:52:06,929 [salt.utils.parsers:1053][WARNING ][26685] Master received a SIGTERM. Exiting.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

If this issue is closed prematurely, please leave a comment and we will gladly reopen the issue.

[waynew]

Was this just due to needing a fallback branch?

[stale]

Thank you for updating this issue. It is no longer marked as stale.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

If this issue is closed prematurely, please leave a comment and we will gladly reopen the issue.

[sagetherage]

@waynew does this still need follow up, assigning for you to decide and move it forward appropriately.

[stale]

Thank you for updating this issue. It is no longer marked as stale.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

If this issue is closed prematurely, please leave a comment and we will gladly reopen the issue.