2019.2.0: pkg.installed tries to push unicoded strings to apt

[syphernl]

Description of Issue/Question

pkg.installed is feeding unicode values to apt which is causing state failures:

[INFO    ] Running state [u'grafana'] at time 13:47:36.741874
[INFO    ] Executing state pkg.installed for [u'grafana']
[DEBUG   ] Could not LazyLoad pkg.resolve_capabilities: 'pkg.resolve_capabilities' is not available.
[DEBUG   ] Could not LazyLoad pkg.normalize_name: 'pkg.normalize_name' is not available.
[DEBUG   ] Could not LazyLoad pkg.check_db: 'pkg.check_db' is not available.
[DEBUG   ] Could not LazyLoad pkg.normalize_name: 'pkg.normalize_name' is not available.
[INFO    ] Executing command [u'dpkg', u'--get-selections', u'*'] in directory '/home/vagrant'
[DEBUG   ] key: systemd.scope, ret: _|-
[INFO    ] Executing command [u'systemd-run', u'--scope', u'apt-get', u'-q', u'-y', u'-o', u'DPkg::Options::=--force-confold', u'-o', u'DPkg::Options::=--force-confdef', u'install', u"u'grafana'"] in directory '/home/vagrant'
[ERROR   ] Command '[u'systemd-run', u'--scope', u'apt-get', u'-q', u'-y', u'-o', u'DPkg::Options::=--force-confold', u'-o', u'DPkg::Options::=--force-confdef', u'install', u"u'grafana'"]' failed with return code: 100
[ERROR   ] stdout: Reading package lists...
Building dependency tree...
Reading state information...
[ERROR   ] stderr: Running scope as unit: run-r9608d9c90f5f483e8a871a8e79df611d.scope
E: Unable to locate package u'grafana'
[ERROR   ] retcode: 100
[INFO    ] Executing command [u'dpkg-query', u'--showformat', u'${Status} ${Package} ${Version} ${Architecture}', u'-W'] in directory '/home/vagrant'
[ERROR   ] Problem encountered installing package(s). Additional info follows:

errors:
    - Running scope as unit: run-r9608d9c90f5f483e8a871a8e79df611d.scope
      E: Unable to locate package u'grafana'

Setup

Using the Grafana formula, which boils down to:

grafana_packages:
  pkg.installed:
  - names: {{ server.pkgs }}

server.pkgs is:

- grafana

Steps to Reproduce Issue

See above

Versions Report

Salt Version:
           Salt: 2019.2.0
 
Dependency Versions:
           cffi: Not Installed
       cherrypy: Not Installed
       dateutil: 2.6.1
      docker-py: Not Installed
          gitdb: Not Installed
      gitpython: Not Installed
          ioflo: Not Installed
         Jinja2: 2.10
        libgit2: Not Installed
        libnacl: Not Installed
       M2Crypto: Not Installed
           Mako: 1.0.7
   msgpack-pure: Not Installed
 msgpack-python: 0.5.6
   mysql-python: Not Installed
      pycparser: Not Installed
       pycrypto: 2.6.1
   pycryptodome: Not Installed
         pygit2: Not Installed
         Python: 2.7.15rc1 (default, Nov 12 2018, 14:31:15)
   python-gnupg: 0.4.1
         PyYAML: 3.12
          PyZMQ: 16.0.2
           RAET: Not Installed
          smmap: Not Installed
        timelib: Not Installed
        Tornado: 4.5.3
            ZMQ: 4.2.5
 
System Versions:
           dist: Ubuntu 18.04 bionic
         locale: UTF-8
        machine: x86_64
        release: 4.15.0-29-generic
         system: Linux
        version: Ubuntu 18.04 bionic

[Ch3LL]

you will need to use the |tojson filter like so:

grafana_packages:                                                                                                                                                                                
  pkg.installed:                                                                                                                                                                                 
  - names: {{ server.pkgs|tojson }}

due to this change: #48309

which was included in the fluorine release notes here: https://docs.saltstack.com/en/develop/topics/releases/2019.2.0.html#non-backward-compatible-change-to-yaml-renderer

[vutny]

Does the Salt serialization extension still works for YAML?
I mean, does this {{ data|yaml }} filter produce correct "yamlified" strings as described here:
https://docs.saltstack.com/en/latest/ref/renderers/all/salt.renderers.jinja.html

[Ch3LL]

I just tested both |yaml and |json and they work as well for this test case.

[vutny]

Awesome, thank you very much @Ch3LL !

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

If this issue is closed prematurely, please leave a comment and we will gladly reopen the issue.