Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Salt does not allow custom validation dates to be specified for new X509 certificates #53148

Closed
jeduardo opened this issue May 21, 2019 · 3 comments
Labels
Confirmed Salt engineer has confirmed bug/feature - often including a MCVE Execution-Module Feature new functionality including changes to functionality and code refactors, etc. State-Module
Milestone

Comments

@jeduardo
Copy link
Contributor

Description of Issue/Question

The current Salt x509 support issues certificates based on the current timestamp when the module is invoked as the starting date ("not_before") and with the expiration date ("not_after") being calculated based on a number of validity dates.

I would like to make it possible to issue certificates with well-defined expiration dates, however when passing dates as not_before and not_after attributes for the X509 state, these attributes are ignored.

Setup

(Please provide relevant configs and/or SLS files (Be sure to remove sensitive info).)

Steps to Reproduce Issue

(Include debug logs if possible and relevant.)

Versions Report

(Provided by running salt --versions-report. Please also mention any differences in master/minion versions.)

@twangboy twangboy added Execution-Module Feature new functionality including changes to functionality and code refactors, etc. State-Module labels May 21, 2019
@twangboy twangboy added this to the Approved milestone May 21, 2019
@stale
Copy link

stale bot commented Jan 8, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

If this issue is closed prematurely, please leave a comment and we will gladly reopen the issue.

@stale stale bot added the stale label Jan 8, 2020
@sagetherage sagetherage added the Confirmed Salt engineer has confirmed bug/feature - often including a MCVE label Jan 9, 2020
@stale
Copy link

stale bot commented Jan 9, 2020

Thank you for updating this issue. It is no longer marked as stale.

@stale stale bot removed the stale label Jan 9, 2020
@waynew
Copy link
Contributor

waynew commented May 23, 2020

Fixed in #53149

@waynew waynew closed this as completed May 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Confirmed Salt engineer has confirmed bug/feature - often including a MCVE Execution-Module Feature new functionality including changes to functionality and code refactors, etc. State-Module
Projects
None yet
Development

No branches or pull requests

4 participants