saltify driver issues with grain and updating minion #54519
Labels
Feature
new functionality including changes to functionality and code refactors, etc.
Grains
Salt-Cloud
Windows
Projects
Milestone
Description of Issue
After deploying a Linux (CentOS) and a Windows minion using Saltify driver, I've observed the presence of a grain salt-cloud in Linux minion (set automatically by Saltify driver) that is not present in Windows minion.
Also I found odd behavior trying to use Saltify to update minions (which would be desirable feature), comparing when it's used to update minions that were installed manually vs minions that were installed using saltify
The presence of this grain is used by the driver to prevent the deployment of Salt Minion on an already saltified system.
I have modified the code a bit to ignore this grain to allow re-deployment. I could have deleted the grain on the minion if needed too.
I would suggest the following changes:
3. Extend the driver to permit not only fresh install, but also update of Salt Minion version (in all platforms).
In my tests, I was able to upgrade minion from 2018.3.4 to 2019.2.0:
ONLY IF existing minion was installed using Saltify.
IF minion was installed manually, Saltify was not able to update the Minion.
It would be really nice and convenient to use Saltify to install on fresh minions and update existing minions.
Steps to Reproduce Issue
on clean minions (make sure no trace of previous minion, salt repo, salt config is present)
Use saltify to deploy windows to new systems (linux and windows) (try with 2018.3.4)
Once system saltified, use Saltify again to update the minion (try with 2019.2.0)
Should work OK.
Now on clean minions (make sure no trace of previous minion, salt repo, salt config is present)
Install salt-minion manually (Windows and Linux, 2018.3.4)
Try to use Saltify to update to 2019.2.0.
I got an error
Versions Report
2019.2.0
minions 2018.3.4 and 2019.2.0, python2 and python3
The text was updated successfully, but these errors were encountered: