boto_secgroup is using group's Name, not the usual tag:Name - breaking both execution (.run) and state (.instance_present) modules if Name and tag:Name are different

[nnsense]

Description of Issue

So far, I've seen salt referring to tag:Name in its boto modules. I've had to figure out myself boto_secgroup is actually using the Name, not the usual tag:Name. For consistency, the tag:Name should be used to manage AWS Security groups. This has important consequences because this module is used by boto_ec2.run, which is turn used by boto_ec2.instance_present. Basically if we're trying to use default SG's name in instance_present bith state and module will fail.

This is Checking all Security groups, we see that every security group has a name, and a tag:Name. Usually, these are identical, but with the default group, the Name will be 'default' while the tag:Name will be the one we've defined.

salt-call boto_secgroup.get_all_security_groups

If I try searching for the SG by using the tag name 'SG-NAT' instead of the Name 'default', salt returns nothing.

The following will return 'False' ('SG-NAT' is the tag Name of the default group)

salt-call boto_secgroup.get_group_id 'SG-NAT' vpc_name='VPC-SALT'

This will instead successfully find the group's ID

salt-call boto_secgroup.get_group_id 'default' vpc_name='VPC-SALT'

For consistency with other modules, this module should only use tags.
Or at least this peculiarity should be documented..

Versions Report

Salt Version:
           Salt: 2019.2.2
 
Dependency Versions:
           cffi: 1.6.0
       cherrypy: unknown
       dateutil: 2.8.0
      docker-py: Not Installed
          gitdb: Not Installed
      gitpython: Not Installed
          ioflo: Not Installed
         Jinja2: 2.7.2
        libgit2: Not Installed
        libnacl: Not Installed
       M2Crypto: 0.31.0
           Mako: Not Installed
   msgpack-pure: Not Installed
 msgpack-python: 0.5.6
   mysql-python: Not Installed
      pycparser: 2.14
       pycrypto: 2.6.1
   pycryptodome: Not Installed
         pygit2: Not Installed
         Python: 2.7.5 (default, Aug  7 2019, 00:51:29)
   python-gnupg: Not Installed
         PyYAML: 3.11
          PyZMQ: 15.3.0
           RAET: Not Installed
          smmap: Not Installed
        timelib: Not Installed
        Tornado: 4.2.1
            ZMQ: 4.1.4
 
System Versions:
           dist: centos 7.7.1908 Core
         locale: UTF-8
        machine: x86_64
        release: 3.10.0-1062.4.3.el7.x86_64
         system: Linux
        version: CentOS Linux 7.7.1908 Core

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

If this issue is closed prematurely, please leave a comment and we will gladly reopen the issue.

[sagetherage]

not stale

[sagetherage]

I guess I have to write a full dissertation so Stalebot is too botty on the booty of the ticket-y so that I can get this issue to not be STALE. I am not stale. I am not stale.I am not stale.I am not stale.I am not stale.I am not stale.

[sagetherage]

Oh, I took the stale label off, my bad, I wonder what the bot does then?