Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

syndic architecture does not scale #55564

Open
tsaridas opened this issue Dec 9, 2019 · 5 comments
Open

syndic architecture does not scale #55564

tsaridas opened this issue Dec 9, 2019 · 5 comments
Labels
Feature
Milestone

Comments

@tsaridas
Copy link
Contributor

@tsaridas tsaridas commented Dec 9, 2019

Description of Issue

When having multiple syndics with a large number of minion connecting to different syndics saltstack syndic tries to send commands (tcp connection to salt-master) for all of them even if the minion does not exist.

After syndic sends the command then salt-master does figure out which minions are but this is not very performant.

I suggest to check if master has the minion key on the salt-syndic at least for targeting with list so that syndic avoids connecting to salt-master.

The performance issue does not show with small number of minions.

Setup

salt-master (mom) -> syndic -> minion

Steps to Reproduce Issue

not applicable

Versions Report

All versions

@waynew waynew added this to Needs triage in [Test] Triage Dec 9, 2019
@waynew waynew added Feature Pending-Discussion labels Dec 9, 2019
@waynew waynew added this to the Blocked milestone Dec 9, 2019
@waynew
Copy link
Contributor

@waynew waynew commented Dec 9, 2019

I believe that this may be improved in the deltaproxy work that @garethgreenaway is working on.

@waynew waynew moved this from Needs triage to Low priority in [Test] Triage Dec 9, 2019
@stale
Copy link

@stale stale bot commented Jan 8, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

If this issue is closed prematurely, please leave a comment and we will gladly reopen the issue.

@stale stale bot added the stale label Jan 8, 2020
@tsaridas
Copy link
Contributor Author

@tsaridas tsaridas commented Jan 8, 2020

solution is quite simple to this for list targeting. @garethgreenaway can you please comment if I should close the ticket or keep it open ?

@stale
Copy link

@stale stale bot commented Jan 8, 2020

Thank you for updating this issue. It is no longer marked as stale.

@stale stale bot removed the stale label Jan 8, 2020
@sagetherage sagetherage removed the Pending-Discussion label Jan 29, 2020
@sagetherage sagetherage removed this from the Blocked milestone Jan 29, 2020
@sagetherage sagetherage added this to the Approved milestone Jan 29, 2020
@sagetherage
Copy link
Collaborator

@sagetherage sagetherage commented Jan 29, 2020

At this time @tsaridas the Core team won't be working on scaling the syndic architecture in salt, you can find this in our Enterprise solution or you can open a PR for review. I will leave this open, and the Stale bot configuration will skip it with the labelFeature attached. I have also moved it to approved, but only if the community wants to submit PRs for this work at this time. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature
Projects
No open projects
[Test] Triage
  
Low priority
Development

No branches or pull requests

3 participants