svn checkout encoding error

[muscraziest]

Description of Issue

When trying to checkout or update a svn repository and a filename with utf-8 encoding exists then the salt master fails with the following message:

svn: E000022: Can't convert string from 'UTF-8' to native encoding:

Steps to Reproduce Issue

$> git clone https://github.com/muscraziest/error_svn_server_encoding
$> cd error_svn_server_encoding
$> docker-compose up salt-master
Creating network "errorsvnserverencoding_default" with the default driver
Creating errorsvnserverencoding_svn-server_1 ...
Creating errorsvnserverencoding_svn-server_1 ... done
Creating errorsvnserverencoding_salt-master_1 ...
Creating errorsvnserverencoding_salt-master_1 ... done
Attaching to errorsvnserverencoding_salt-master_1
salt-master_1  | [ERROR   ] Command '['svn', '--non-interactive', 'checkout', 'svn://svn-server/testrepo']' failed with return code: 1
salt-master_1  | [ERROR   ] stdout: A    testrepo/t{U+03B5}st
salt-master_1  | [ERROR   ] stderr: svn: E155009: Failed to run the WC DB work queue associated with '/tmp/testrepo', work item 1 (file-install t{U+03B5}st 1 0 1 1)
salt-master_1  | svn: E000022: Can't convert string from 'UTF-8' to native encoding:
salt-master_1  | svn: E000022: /tmp/testrepo/t{U+03B5}st
salt-master_1  | [ERROR   ] retcode: 1
salt-master_1  | Exception occurred in runner salt.cmd: Traceback (most recent call last):
salt-master_1  |   File "/usr/lib/python3/dist-packages/salt/client/mixins.py", line 387, in _low
salt-master_1  |     data['return'] = self.functions[fun](*args, **kwargs)
salt-master_1  |   File "/usr/lib/python3/dist-packages/salt/runners/salt.py", line 106, in cmd
salt-master_1  |     if fun in functions \
salt-master_1  |   File "/usr/lib/python3/dist-packages/salt/modules/svn.py", line 174, in checkout
salt-master_1  |     return _run_svn('checkout', cwd, user, username, password, opts)
salt-master_1  |   File "/usr/lib/python3/dist-packages/salt/modules/svn.py", line 73, in _run_svn
salt-master_1  |     raise CommandExecutionError(result['stderr'] + '\n\n' + ' '.join(cmd))
salt-master_1  | salt.exceptions.CommandExecutionError: svn: E155009: Failed to run the WC DB work queue associated with '/tmp/testrepo', work item 1 (file-install t{U+03B5}st 1 0 1 1)
salt-master_1  | svn: E000022: Can't convert string from 'UTF-8' to native encoding:
salt-master_1  | svn: E000022: /tmp/testrepo/t{U+03B5}st
salt-master_1  |
salt-master_1  | svn --non-interactive checkout svn://svn-server/testrepo

Versions Report

Salt Version:
Salt: 2018.3.4

Dependency Versions:
cffi: 1.12.1
cherrypy: unknown
dateutil: Not Installed
docker-py: 1.10.6
gitdb: 2.0.5
gitpython: 2.1.11
ioflo: 1.7.5
Jinja2: 2.8
libgit2: 0.27.7
libnacl: 1.6.1
M2Crypto: 0.31.0
Mako: 1.0.7
msgpack-pure: Not Installed
msgpack-python: 0.4.6
mysql-python: Not Installed
pycparser: 2.19
pycrypto: 3.7.2
pycryptodome: Not Installed
pygit2: 0.27.2
Python: 3.5.2 (default, Nov 12 2018, 13:43:14)
python-gnupg: Not Installed
PyYAML: 3.11
PyZMQ: 15.2.0
RAET: 0.6.8
smmap: 2.0.5
timelib: 0.2.4
Tornado: 4.2.1
ZMQ: 4.1.4

System Versions:
dist: Ubuntu 16.04 xenial
locale: ANSI_X3.4-1968
machine: x86_64
release: 5.4.7-100.fc30.x86_64
system: Linux
version: Ubuntu 16.04 xenial

[muscraziest]

It seems the issue comes from cmd.run invocation with a clean enviroment (missing locale information)

[Ch3LL]

can you share the state or execution module command you are using when you see this?

[muscraziest]

the command is salt-run salt.cmd svn.checkout /tmp svn://svn-server/testrepo

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

If this issue is closed prematurely, please leave a comment and we will gladly reopen the issue.

[Ch3LL]

thanks for clarifying the command. looks like we need to handle the encoding here better. thanks

[stale]

Thank you for updating this issue. It is no longer marked as stale.