Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jobs.lookup_jid is too verbose if cmd.script was used - filtering options please? #55929

Open
ScriptJunky opened this issue Jan 22, 2020 · 3 comments
Labels
Feature new functionality including changes to functionality and code refactors, etc.
Milestone

Comments

@ScriptJunky
Copy link

ScriptJunky commented Jan 22, 2020

salt -G roles:webservers cmd.script salt://scripts/open.java.versions --async

Calling the output when using CLI will always produce stuff that we don't really care to see at the point in time (pid, retcode, stderr);

-0-root@saltmaster:/srv/salt/scripts # salt-run jobs.lookup_jid 20200122041547835372
webserver001:
    ----------
    pid:
        30126
    retcode:
        0
    stderr:
    stdout:
        Running Java: oracle_jdk-1.8.0_11
webserver002:
    ----------
    pid:
        32282
    retcode:
        0
    stderr:
    stdout:
        Running Java: oracle_jdk-1.8.0_11

Could a way to filter this output be added to jobs.lookup_jid?

@ScriptJunky ScriptJunky changed the title [Feature Request] jobs.lookup_jid is to verbose if cmd.script was used - filtering options??? jobs.lookup_jid is too verbose if cmd.script was used - filtering options please? Jan 22, 2020
@xeacott
Copy link
Contributor

xeacott commented Jan 22, 2020

So instead something like this... where only stdout is shown?

-0-root@saltmaster:/srv/salt/scripts # salt-run jobs.lookup_jid 20200122041547835372

webserver001:
    ----------
    Running Java: oracle_jdk-1.8.0_11

webserver002:
    ----------
    Running Java: oracle_jdk-1.8.0_11

I actually don't know maybe using a different out-putter can achieve this but otherwise it would be a feature request. But, I'll ping @saltstack/team-core in case there already is something built in to achieve this. :)

@xeacott xeacott added Pending-Discussion The issue or pull request needs more discussion before it can be closed or merged Feature new functionality including changes to functionality and code refactors, etc. labels Jan 22, 2020
@xeacott xeacott added this to the Blocked milestone Jan 22, 2020
@ScriptJunky
Copy link
Author

ScriptJunky commented Jan 22, 2020

Yes that exactly, or some means to filter like maybe;

--filter stdout
or
--filter stderr,pid

That would allow a bit more granular control as some folks might want something other than stdout, or more than just stdout but not everything....

@sagetherage sagetherage removed the Pending-Discussion The issue or pull request needs more discussion before it can be closed or merged label Jan 24, 2020
@sagetherage sagetherage removed this from the Blocked milestone Jan 24, 2020
@sagetherage
Copy link
Contributor

Discussed with team-core 1/24/2020 at this time the core team will keep this in the backlog as lower priority and the community is welcome to submit a PR or use as suggested ^^ to use a filter.

@sagetherage sagetherage added the P4 Priority 4 label Jan 24, 2020
@sagetherage sagetherage modified the milestones: Approved, Blocked Feb 7, 2020
@sagetherage sagetherage removed the P4 Priority 4 label Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature new functionality including changes to functionality and code refactors, etc.
Projects
None yet
Development

No branches or pull requests

3 participants