Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hashutil.github_signature does not recognize sha argument #58130

Open
sootythebear opened this issue Aug 4, 2020 · 1 comment
Open

hashutil.github_signature does not recognize sha argument #58130

sootythebear opened this issue Aug 4, 2020 · 1 comment
Labels
Bug broken, incorrect, or confusing behavior docstring-update string edits Documentation Relates to Salt documentation module doc standards severity-low 4th level, cosemtic problems, work around exists time-estimate-sprint
Milestone

Comments

@sootythebear
Copy link

Description of Issue

Executing salt <minion> hashutil.github_signature '{"ref":....} ' 'shared secret' 'sha1=<key> returns the error:

ERROR executing 'hashutil.github_signature': The following keyword arguments are not valid: sha1=c12560e6fe48bf2a1e96119a81ffb9d3ee033717

Setup

GitHub Webhook configured for push event.

For the string, cut-n-paste either the payload from GitHub Webhook Recent Deliveries request section or via the event bus. challenge_hmac comes from either location.

Steps to Reproduce Issue

(Include debug logs if possible and relevant.)

Versions Report

(Provided by running salt --versions-report. Please also mention any differences in master/minion versions.)

salt --versions-report
Salt Version:
           Salt: 3001

Dependency Versions:
           cffi: Not Installed
       cherrypy: unknown
       dateutil: 2.6.1
      docker-py: Not Installed
          gitdb: 2.0.3
      gitpython: 2.1.8
         Jinja2: 2.10
        libgit2: Not Installed
       M2Crypto: Not Installed
           Mako: Not Installed
   msgpack-pure: Not Installed
 msgpack-python: 0.5.6
   mysql-python: 1.3.10
      pycparser: Not Installed
       pycrypto: 2.6.1
   pycryptodome: 3.4.7
         pygit2: Not Installed
         Python: 3.6.9 (default, Apr 18 2020, 01:56:04)
   python-gnupg: 0.4.1
         PyYAML: 3.12
          PyZMQ: 17.1.2
          smmap: 2.0.3
        timelib: Not Installed
        Tornado: 4.5.3
            ZMQ: 4.2.5

System Versions:
           dist: ubuntu 18.04 Bionic Beaver
         locale: UTF-8
        machine: x86_64
        release: 4.15.0-111-generic
         system: Linux
        version: Ubuntu 18.04 Bionic Beaver
@sootythebear
Copy link
Author

Noticed that sha1=<value> was being parsed as a key=value pair, workaround was to specify as follows:

challenge_hmac='sha1=c12560e6fe48bf2a1e96119a81ffb9d3ee033717'

@sagetherage sagetherage added Bug broken, incorrect, or confusing behavior docstring-update string edits severity-low 4th level, cosemtic problems, work around exists labels Aug 7, 2020
@sagetherage sagetherage added this to the Approved milestone Aug 7, 2020
@ScriptAutomate ScriptAutomate added the Documentation Relates to Salt documentation label Sep 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug broken, incorrect, or confusing behavior docstring-update string edits Documentation Relates to Salt documentation module doc standards severity-low 4th level, cosemtic problems, work around exists time-estimate-sprint
Projects
None yet
Development

No branches or pull requests

4 participants