Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Salt-Cloud provider for Digital Ocean requires a way to specify the VPC to use #58265

Open
Nexinal opened this issue Aug 21, 2020 · 1 comment
Assignees
Labels
Feature new functionality including changes to functionality and code refactors, etc. Needs-Testcase PR needs test cases written, or the issue is about a bug/feature that needs test cases
Milestone

Comments

@Nexinal
Copy link

Nexinal commented Aug 21, 2020

The Salt-Cloud provider for Digital Ocean (DO) allows you to connect the new VM/Droplet to private networking using DO's VPC functionality but doesn't allow you to specify the VPC you want to connect to, it only uses the default VPC as specified in your DO account. Unfortunately, DO also don't allow you to change the default.

A sample provider.conf file would be along the lines of:

digital-ocean:
   private_networking: true
   vpc:  my-vpc-name

which would translate to adding the vpc_uuid parameter in the API call to DO.

@Nexinal Nexinal added the Feature new functionality including changes to functionality and code refactors, etc. label Aug 21, 2020
@Nexinal Nexinal changed the title Salt-Cloud provider for Digital Ocean requires a way to specify the PVC to use Salt-Cloud provider for Digital Ocean requires a way to specify the VPC to use Aug 21, 2020
@sagetherage sagetherage assigned Ch3LL and unassigned Akm0d Sep 1, 2020
@Ch3LL Ch3LL removed the needs-triage label Sep 1, 2020
@Ch3LL Ch3LL added this to the Approved milestone Sep 1, 2020
@Ch3LL Ch3LL removed their assignment Sep 1, 2020
@sagetherage sagetherage added phase-plan Needs-Testcase PR needs test cases written, or the issue is about a bug/feature that needs test cases labels Dec 14, 2020
@sagetherage
Copy link
Contributor

@waynew this is good one for Test Clinic since it has a PR that needs a test case. Assigning you only for that reason and won't put into a committed release until tests are written.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature new functionality including changes to functionality and code refactors, etc. Needs-Testcase PR needs test cases written, or the issue is about a bug/feature that needs test cases
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants