Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] Add mountpoint parameter to zpool.present state #59181

Open
dkacar-oradian opened this issue Dec 21, 2020 · 0 comments
Open
Labels
Feature new functionality including changes to functionality and code refactors, etc.
Milestone

Comments

@dkacar-oradian
Copy link

Is your feature request related to a problem? Please describe.
It's impossible to mount zpool created by zpool.present state to the arbitrary location in the file system hierarchy because it doesn't accept mountpoint argument (-m option to zpool create), so it will always go to the default location. This is highly undesirable in some circumstances. For example, I'm currently porting something that's using BTRFS to ZFS and it would be really nice if the file system hierarchy could stay the same.

Describe the solution you'd like
zpool.present state should accept mountpoint parameter, probably as a property in the config parameter.
Note that the zpool.create module accepts mountpoint, so the state should just accept it and pass it on because it's already using that module to create zpool if it doesn't exist. In other words, I expect this to be a very small code addition.

Describe alternatives you've considered
At the moment I had to ignore zpool.present state. Instead I've created a stateful script which accepts all parameters I care about and calls zpool create directly. That works, but doesn't have all the features that the zpool.present state has, so it isn't really a desirable alternative.

Additional context
Add any other context or screenshots about the feature request here.

Please Note
If this feature request would be considered a substantial change or addition, this should go through a SEP process here https://github.com/saltstack/salt-enhancement-proposals, instead of a feature request.

@dkacar-oradian dkacar-oradian added the Feature new functionality including changes to functionality and code refactors, etc. label Dec 21, 2020
@sagetherage sagetherage assigned krionbsd and unassigned s0undt3ch Apr 6, 2021
@sagetherage sagetherage added this to the Approved milestone Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature new functionality including changes to functionality and code refactors, etc.
Projects
None yet
Development

No branches or pull requests

4 participants