Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] 2017.7 win_iis.deployed does not update values #59780

Open
iHarshalAgarwal opened this issue Mar 11, 2021 · 4 comments
Open

[BUG] 2017.7 win_iis.deployed does not update values #59780

iHarshalAgarwal opened this issue Mar 11, 2021 · 4 comments
Assignees
Labels
Bug broken, incorrect, or confusing behavior severity-high 2nd top severity, seen by most users, causes major problems State-Module Windows
Projects

Comments

@iHarshalAgarwal
Copy link

iHarshalAgarwal commented Mar 11, 2021

Description
win_iis.deployed does not update the values, if the site exists in IIS with some other configuration settings.

Setup
pillar:

  - siteName: 'mysite'
    sourcePath: 'C:\\inetpub\\mysite
    appPool: 'somepool'
    port: 81
    protocol: 'http'

salt:

add_{{ sites['siteName'] }}_site":
  win_iis.deployed:
    - name: {{ sites['siteName'] }}
    - sourcepath: {{ sites['sourcePath'] }}
    - apppool: {{ sites['appPool'] }}
    - port: {{ sites['port'] }}
    - protocol: {{ sites['protocol'] }}

Steps to Reproduce the behavior

  1. Run the above state with some values.
  2. Expect the site to be created.
  3. Update port from 81 to 82 and rerun

Expected behavior
It should update the port for that site in IIS

Screenshots
Result: comment: Site already present: mysite

Versions Report
master version: 2017.7.4 (Nitrogen) - this is on Ubuntu
minions version: - 3002.5 - this is on windows

@iHarshalAgarwal iHarshalAgarwal added Bug broken, incorrect, or confusing behavior needs-triage labels Mar 11, 2021
@welcome
Copy link

welcome bot commented Mar 11, 2021

Hi there! Welcome to the Salt Community! Thank you for making your first contribution. We have a lengthy process for issues and PRs. Someone from the Core Team will follow up as soon as possible. In the meantime, here’s some information that may help as you continue your Salt journey.
Please be sure to review our Code of Conduct. Also, check out some of our community resources including:

There are lots of ways to get involved in our community. Every month, there are around a dozen opportunities to meet with other contributors and the Salt Core team and collaborate in real time. The best way to keep track is by subscribing to the Salt Community Events Calendar.
If you have additional questions, email us at core@saltstack.com. We’re glad you’ve joined our community and look forward to doing awesome things with you!

@sagetherage
Copy link
Contributor

@iHarshalAgarwal your master is running an unsupported version of Salt are you able to upgrade to something that is supported? >v3000 See our Platform Support Page for details

@sagetherage sagetherage added the info-needed waiting for more info label Mar 11, 2021
@sagetherage sagetherage self-assigned this Mar 11, 2021
@sagetherage sagetherage added this to To do in Windows via automation Mar 11, 2021
@sagetherage sagetherage added this to the Blocked milestone Mar 11, 2021
@iHarshalAgarwal
Copy link
Author

I'll look at it. Thanks @sagetherage

@sagetherage sagetherage changed the title win_iis.deployed does not update values [BUG] 2017.7 win_iis.deployed does not update values Mar 15, 2021
@twangboy
Copy link
Contributor

Yeah, looks like the state only checks for the presence of the site and nothing else.

@twangboy twangboy added severity-high 2nd top severity, seen by most users, causes major problems State-Module and removed info-needed waiting for more info needs-triage labels Apr 16, 2021
@twangboy twangboy modified the milestones: Blocked, Approved Apr 16, 2021
@sagetherage sagetherage assigned twangboy and xeacott and unassigned sagetherage Apr 30, 2021
@sagetherage sagetherage added the Phosphorus v3005.0 Release code name and version label Jun 18, 2021
@sagetherage sagetherage modified the milestones: Approved, Phosphorus Jun 18, 2021
@twangboy twangboy added Sulfur v3006.0 release code name and version and removed Phosphorus v3005.0 Release code name and version labels Mar 2, 2022
@waynew waynew removed the Sulfur v3006.0 release code name and version label Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug broken, incorrect, or confusing behavior severity-high 2nd top severity, seen by most users, causes major problems State-Module Windows
Projects
Windows
  
To do
Development

No branches or pull requests

5 participants