Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE REQUEST] Longer domain handling in salt-cloud digitalocean provider #61267

Open
waynegemmell opened this issue Nov 19, 2021 · 0 comments
Open

[FEATURE REQUEST] Longer domain handling in salt-cloud digitalocean provider #61267

waynegemmell opened this issue Nov 19, 2021 · 0 comments
Assignees
@garethgreenaway
Labels
Feature new functionality including changes to functionality and code refactors, etc.
Milestone
Approved

Comments

@waynegemmell
Copy link
Contributor

The digitalocean provider only handles domains that have two parts. Our domains have three parts, xyz.co.za. The domain name that is setup is then co.za instead of xyz.co.za

Currently the code looks like this.

default_dns_hostname = ".".join(dns_domain_name[:-2])
default_dns_domain = ".".join(dns_domain_name[-2:])

It should use length - 1 instead of "-2:" to ensure that the whole domain is captured.
@waynegemmell waynegemmell added Feature new functionality including changes to functionality and code refactors, etc. needs-triage labels Nov 19, 2021
@garethgreenaway garethgreenaway added this to the Approved milestone Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@garethgreenaway garethgreenaway

Labels
Feature new functionality including changes to functionality and code refactors, etc.
Projects
None yet
Milestone
Approved
Development

No branches or pull requests
2 participants
@waynegemmell @garethgreenaway