You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
It is not possible to use the ps.pkill command with the full=true option to kill a script without also killing the salt process doing the command. This is illustrated by pgrep, which returns the processes we are interested in but also the salt processes running the command:
Additionally the documentation talks about the parameter of both commands being a "pattern", however, looking at the source (https://github.com/saltstack/salt/blob/master/salt/modules/ps.py#L300) just a simple python str "in" operator is used.... so it isn't so much a pattern as a substring.
There are though other solution that are possible. For example, the ps.psaux command removed salt instances from the results - making pkill/psaux consistent with this would also be welcome.
Describe the solution you'd like
Don't include salt commands in the process set and support regexs (or update the parameter name from 'pattern' to 'substring')
Describe alternatives you've considered
Just supporting pattern being a regex would be sufficient
Additional context
Add any other context or screenshots about the feature request here.
Hi there! Welcome to the Salt Community! Thank you for making your first contribution. We have a lengthy process for issues and PRs. Someone from the Core Team will follow up as soon as possible. In the meantime, here’s some information that may help as you continue your Salt journey.
Please be sure to review our Code of Conduct. Also, check out some of our community resources including:
There are lots of ways to get involved in our community. Every month, there are around a dozen opportunities to meet with other contributors and the Salt Core team and collaborate in real time. The best way to keep track is by subscribing to the Salt Community Events Calendar.
If you have additional questions, email us at saltproject@vmware.com. We’re glad you’ve joined our community and look forward to doing awesome things with you!
Is your feature request related to a problem? Please describe.
It is not possible to use the ps.pkill command with the full=true option to kill a script without also killing the salt process doing the command. This is illustrated by pgrep, which returns the processes we are interested in but also the salt processes running the command:
Additionally the documentation talks about the parameter of both commands being a "pattern", however, looking at the source (https://github.com/saltstack/salt/blob/master/salt/modules/ps.py#L300) just a simple python str "in" operator is used.... so it isn't so much a pattern as a substring.
Both of these issues can be solved by allowing pattern to be a regex, similar to what is used in the ps.psaux function (https://github.com/saltstack/salt/blob/master/salt/modules/ps.py#L745)
There are though other solution that are possible. For example, the ps.psaux command removed salt instances from the results - making pkill/psaux consistent with this would also be welcome.
Describe the solution you'd like
Don't include salt commands in the process set and support regexs (or update the parameter name from 'pattern' to 'substring')
Describe alternatives you've considered
Just supporting pattern being a regex would be sufficient
Additional context
Add any other context or screenshots about the feature request here.
Please Note
If this feature request would be considered a substantial change or addition, this should go through a SEP process here https://github.com/saltstack/salt-enhancement-proposals, instead of a feature request.
The text was updated successfully, but these errors were encountered: