Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

job arguments are set by job_args key and not args. #63430

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

amaanu92
Copy link

@amaanu92 amaanu92 commented Jan 7, 2023

I spent a lot of time scheduling a job in salt 3004.1 and 3005.1 on a windows minion. I found at https://docs.saltproject.io/salt/user-guide/en/latest/topics/scheduler.html#declaring-scheduled-jobs that job_args should be used not args which worked for me.

What does this PR do?

What issues does this PR fix or reference?

Fixes: args parameter name

Previous Behavior

Remove this section if not relevant

New Behavior

Remove this section if not relevant

Merge requirements satisfied?

[NOTICE] Bug fixes or features added to Salt require tests.

Commits signed with GPG?

Yes/No

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

I spent a lot of time scheduling a job in salt 3004.1 and 3..5.1. I found at
https://docs.saltproject.io/salt/user-guide/en/latest/topics/scheduler.html#declaring-scheduled-jobs
that job_args should be used not agrs.
@amaanu92 amaanu92 requested a review from a team as a code owner January 7, 2023 19:14
@amaanu92 amaanu92 requested review from cmcmarrow and removed request for a team January 7, 2023 19:14
@welcome
Copy link

welcome bot commented Jan 7, 2023

Hi there! Welcome to the Salt Community! Thank you for making your first contribution. We have a lengthy process for issues and PRs. Someone from the Core Team will follow up as soon as possible. In the meantime, here’s some information that may help as you continue your Salt journey.
Please be sure to review our Code of Conduct. Also, check out some of our community resources including:

There are lots of ways to get involved in our community. Every month, there are around a dozen opportunities to meet with other contributors and the Salt Core team and collaborate in real time. The best way to keep track is by subscribing to the Salt Community Events Calendar.
If you have additional questions, email us at saltproject@vmware.com. We’re glad you’ve joined our community and look forward to doing awesome things with you!

@cmcmarrow cmcmarrow added the Documentation Relates to Salt documentation label Mar 6, 2023
@barbaricyawps barbaricyawps requested review from barbaricyawps and removed request for barbaricyawps May 31, 2023 17:34
@barbaricyawps barbaricyawps removed the Documentation Relates to Salt documentation label May 31, 2023
@dwoz dwoz added this to the Argon v3008.0 milestone Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants